Issue 8267045: code review 8267045: go/parser: ParseExpr must accept type expressions

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8267045: code review 8267045: go/parser: ParseExpr must accept type expressions (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by gri

Modified:
12 years, 1 month ago

Reviewers:

CC:
golang-dev, adg

Visibility:
Public.

Description

go/parser: ParseExpr must accept type expressions My old code was trying to be too smart. Also: Slightly better error message format for gofmt -r pattern errors. Fixes issue 4406.

Patch Set 1 #

Patch Set 2 : diff -r 56b90ebca903 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 56b90ebca903 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 56b90ebca903 https://code.google.com/p/go/ #

Patch Set 5 : diff -r aa1ff597baa5 https://code.google.com/p/go/ #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -12 lines)			Patch
M	src/cmd/gofmt/gofmt_test.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/gofmt/rewrite.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
A	src/cmd/gofmt/testdata/rewrite8.golden	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
A	src/cmd/gofmt/testdata/rewrite8.input	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
M	src/pkg/go/parser/interface.go	View	1 2	1 chunk	+20 lines, -9 lines	0 comments	Download
M	src/pkg/go/parser/parser_test.go	View	1	2 chunks	+12 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

12 years, 1 month ago (2013-04-03 03:12:09 UTC) #1

gri

12 years, 1 month ago (2013-04-03 14:41:30 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=2274dd52bc48 ***

go/parser: ParseExpr must accept type expressions

My old code was trying to be too smart.
Also: Slightly better error message format
for gofmt -r pattern errors.

Fixes issue 4406.

R=golang-dev, adg
CC=golang-dev
https://codereview.appspot.com/8267045

Expand All Messages | Collapse All Messages