Restore dots that overflow chords; issue 3179

Remove dots that overflow chords, working individually on each voice; issue 3179

[Trevor Daniels, 2013-04-07 07:51:08]

Patch set 2 looks promising, but in view of the
imminence of next stable and the subtlety of the
effect of this patch it is probably best left to
the start of a new development release, as Keith
hints.

Trevor

[lemzwerg, 2013-04-08 06:42:45]

LGTM, with minor nits.  Thanks for the patch!

https://codereview.appspot.com/8266047/diff/15001/input/regression/chord-dots.ly
File input/regression/chord-dots.ly (left):

https://codereview.appspot.com/8266047/diff/15001/input/regression/chord-dots...
input/regression/chord-dots.ly:21: }
Please extend the regtest so that it covers double dotted notes and chords also.

https://codereview.appspot.com/8266047/diff/15001/lily/dot-column.cc
File lily/dot-column.cc (right):

https://codereview.appspot.com/8266047/diff/15001/lily/dot-column.cc#newcode277
lily/dot-column.cc:277: "note-collision "
Any reason for a non-alphabetical sorting?

[lemzwerg, 2013-04-09 06:30:51]

LGTM, but one patch too much :-)

https://codereview.appspot.com/8266047/diff/19001/ly/titling-init.ly
File ly/titling-init.ly (left):

https://codereview.appspot.com/8266047/diff/19001/ly/titling-init.ly#oldcode144
ly/titling-init.ly:144: 
Oops!  Changes to this file probably don't belong to this tracker issue, right?

[lemzwerg, 2013-11-02 06:40:52]

LGTM, thanks.

https://codereview.appspot.com/8266047/diff/60001/input/regression/chord-dots.ly
File input/regression/chord-dots.ly (right):

https://codereview.appspot.com/8266047/diff/60001/input/regression/chord-dots...
input/regression/chord-dots.ly:12: \override Staff.DotColumn.chord-dots-limit =
#1
What about adding the default case (chord-dots-limit = #3) for comparison?

[Trevor Daniels, 2013-11-02 11:11:39]

LGTM

Trevor

[Keith, 2013-11-02 21:43:00]

On 2013/11/02 06:40:52, lemzwerg wrote:

>
https://codereview.appspot.com/8266047/diff/60001/input/regression/chord-dots...
> input/regression/chord-dots.ly:12: \override Staff.DotColumn.chord-dots-limit
=
> #1
> What about adding the default case (chord-dots-limit = #3) for comparison?

I did include comparisons for the earlier patch review, but for the pushed
regression test I want short output that looks good when the code works, and
looks odd if it ever fails.