Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1479)

Issue 8266043: state: connect less times in tests.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 12 months ago by rog
Modified:
10 years, 12 months ago
Reviewers:
dimitern, mp+156639, TheMue
Visibility:
Public.

Description

state: connect less times in tests. Since state.Initialize opens the state, we might as well use the state that it returns. https://code.launchpad.net/~rogpeppe/juju-core/265-state-use-initialize-result/+merge/156639 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state: connect less times in tests. #

Patch Set 3 : state: connect less times in tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -16 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M state/conn_test.go View 1 chunk +1 line, -5 lines 0 comments Download
M state/export_test.go View 1 chunk +3 lines, -4 lines 0 comments Download
M state/initialize_test.go View 2 chunks +5 lines, -3 lines 0 comments Download
M state/megawatcher_internal_test.go View 1 2 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 4
rog
Please take a look.
10 years, 12 months ago (2013-04-02 17:09:45 UTC) #1
dimitern
Nice, LGTM.
10 years, 12 months ago (2013-04-02 17:21:19 UTC) #2
TheMue
LGTM, looks good.
10 years, 12 months ago (2013-04-02 17:25:15 UTC) #3
rog
10 years, 12 months ago (2013-04-03 12:41:34 UTC) #4
*** Submitted:

state: connect less times in tests.

Since state.Initialize opens the state, we
might as well use the state that it returns.

R=dimitern, TheMue
CC=
https://codereview.appspot.com/8266043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b