Issue 82660044: code review 82660044: include/plan9: make mklibc.rc compatible with 9atom

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 82660044: code review 82660044: include/plan9: make mklibc.rc compatible with 9atom (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 2 months ago by 0intro

Modified:
10 years, 2 months ago

Reviewers:
r, gobot

CC:
golang-codereviews, r

Visibility:
Public.

Description

include/plan9: make mklibc.rc compatible with 9atom Since there is no Runemask constant in UTF-8 enum in 9atom, removing the other constants leads to an empty enum, which is illegal. Thus, we remove enum entirely.

Patch Set 1 #

Patch Set 2 : diff -r 1afdecdd77c1 https://code.google.com/p/go #

Patch Set 3 : diff -r 2114e9e65d6c https://code.google.com/p/go #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -6 lines)			Patch
	M	include/plan9/mklibc.rc	View	1	1 chunk	+1 line, -6 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

0intro

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

10 years, 2 months ago (2014-03-31 19:25:07 UTC) #1

0intro

*** Submitted as https://code.google.com/p/go/source/detail?r=70af843fed44 *** include/plan9: make mklibc.rc compatible with 9atom Since there is no ...

10 years, 2 months ago (2014-04-19 07:55:35 UTC) #3

gobot

10 years, 2 months ago (2014-04-19 08:56:53 UTC) #4

Message was sent while issue was closed.

This CL appears to have broken the plan9-386-cnielsen builder.
See http://build.golang.org/log/00fa6571071a1d0e551664c69b5e9cb9e00eddf4

Expand All Messages | Collapse All Messages