code review 8255044: cmd/gc: preserve safe annotation of package def.

cmd/gc: preserve safe annotation of package def.

A package file may begin as either "package foo" or
"package foo safe". The latter is relevant when using -u.
https://codereview.appspot.com/6903059 resulted in the distinction
being dropped when a package was read for the second or later time.
This CL records whether that "safe" tag was present,
and includes it in the dummy statement generated for the lexer.

[dsymonds, 2013-04-02 13:38:02]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[r, 2013-04-02 13:55:24]

LGTM but get another set of eyes

https://codereview.appspot.com/8255044/diff/5001/src/cmd/gc/go.h
File src/cmd/gc/go.h (right):

https://codereview.appspot.com/8255044/diff/5001/src/cmd/gc/go.h#newcode397
src/cmd/gc/go.h:397: int	safe;
// what it means

[minux1, 2013-04-02 14:13:47]

https://codereview.appspot.com/8255044/diff/5001/src/cmd/gc/go.h
File src/cmd/gc/go.h (right):

https://codereview.appspot.com/8255044/diff/5001/src/cmd/gc/go.h#newcode397
src/cmd/gc/go.h:397: int	safe;
could we make the safe field a char?

[DMorsing, 2013-04-02 14:32:52]

LGTM with minux' suggestion.

[iant, 2013-04-02 16:03:00]

LGTM

It would sure be nice to have a test.  It ought to be possible to write one.

[dsymonds, 2013-04-02 21:26:16]

*** Submitted as https://code.google.com/p/go/source/detail?r=d7e787e80e7d ***

cmd/gc: preserve safe annotation of package def.

A package file may begin as either "package foo" or
"package foo safe". The latter is relevant when using -u.
https://codereview.appspot.com/6903059 resulted in the distinction
being dropped when a package was read for the second or later time.
This CL records whether that "safe" tag was present,
and includes it in the dummy statement generated for the lexer.

R=golang-dev, r, minux.ma, daniel.morsing, iant
CC=golang-dev
https://codereview.appspot.com/8255044

https://codereview.appspot.com/8255044/diff/5001/src/cmd/gc/go.h
File src/cmd/gc/go.h (right):

https://codereview.appspot.com/8255044/diff/5001/src/cmd/gc/go.h#newcode397
src/cmd/gc/go.h:397: int	safe;
On 2013/04/02 14:13:48, minux wrote:
> could we make the safe field a char?

Done.

https://codereview.appspot.com/8255044/diff/5001/src/cmd/gc/go.h#newcode397
src/cmd/gc/go.h:397: int	safe;
On 2013/04/02 13:55:24, r wrote:
> // what it means

Done.