Add network listing by node to test server

Add network listing by node to test server

Implements some support for networks in the MAAS test
server. Only includes the networks/?node=<system_id> api
for now as the others are not required by juju-core at
present.

https://code.launchpad.net/~gz/gomaasapi/maas_list_networks/+merge/213496

(do not edit description out of merge proposal)

[gz, 2014-03-31 15:23:28]

Please take a look.

[dimitern, 2014-04-01 11:24:51]

LGTM, but I'd like someone from the MAAS team to take a look as well. It doesn't
need to be perfect, just to provide us a way to write tests for networks in
juju-core.

[allenap, 2014-04-01 11:33:38]

Looks good to me too. Just a couple of small things to tidy up I think.

https://codereview.appspot.com/82460044/diff/1/testservice.go
File testservice.go (right):

https://codereview.appspot.com/82460044/diff/1/testservice.go#newcode81
testservice.go:81: func getNetworksURI(version, name string) string {
There's a getNetworksURL function later on. Perhaps name this getNetworkURI
(change to non-plural)? Also, neither of them really return a URL/URI, just a
path.

https://codereview.appspot.com/82460044/diff/1/testservice.go#newcode252
testservice.go:252: func getNetworksURL(version string) string {
This can be confused with getNetworksURI earlier on. See comment there.

[gz, 2014-04-01 14:48:45]

Please take a look.

https://codereview.appspot.com/82460044/diff/1/testservice.go
File testservice.go (right):

https://codereview.appspot.com/82460044/diff/1/testservice.go#newcode81
testservice.go:81: func getNetworksURI(version, name string) string {
On 2014/04/01 11:33:39, allenap wrote:
> There's a getNetworksURL function later on. Perhaps name this getNetworkURI
> (change to non-plural)? Also, neither of them really return a URL/URI, just a
> path.

So, this is plural because the endpoint is plural.. but that's not true of the
/nodes/ and /files/ methods above.

https://codereview.appspot.com/82460044/diff/1/testservice.go#newcode252
testservice.go:252: func getNetworksURL(version string) string {
On 2014/04/01 11:33:39, allenap wrote:
> This can be confused with getNetworksURI earlier on. See comment there.

Yeah, it's following the existing style... which is rather confusing. I'll do
some renaming.

[dave_cheney.net, 2014-04-01 19:28:25]

https://codereview.appspot.com/82460044/diff/20001/testservice.go
File testservice.go (right):

https://codereview.appspot.com/82460044/diff/20001/testservice.go#newcode246
testservice.go:246: if !hasNode {
if _, hasNode := ... ; !hasNode { ... }

https://codereview.appspot.com/82460044/diff/20001/testservice.go#newcode247
testservice.go:247: panic("no node with given system id")
log the missing system id ?

https://codereview.appspot.com/82460044/diff/20001/testservice.go#newcode251
testservice.go:251: panic("no network with given name")
same

https://codereview.appspot.com/82460044/diff/20001/testservice.go#newcode254
testservice.go:254: server.networksPerNode[systemId] = append(networkNames,
name)
this can be one line,

server.networksPernode[...] = append(server.networks.., name)

https://codereview.appspot.com/82460044/diff/20001/testservice.go#newcode587
testservice.go:587: systemId := values.Get("node")
if systemId := .... ; systemId == "" { panic() }

https://codereview.appspot.com/82460044/diff/20001/testservice.go#newcode589
testservice.go:589: panic("network missing associated node system id")
log missing id

https://codereview.appspot.com/82460044/diff/20001/testservice.go#newcode594
testservice.go:594: panic("no networks exists for the given node system id")
same