Issue 82390045: unit.SetAddress now takes a vararg

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 82390045: unit.SetAddress now takes a vararg

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 1 month ago by dave

Modified:
10 years ago

Reviewers:
mp+213393, rog

Visibility:
Public.

Description

unit.SetAddress now takes a vararg Update LP#1298770 The previous branch updated instance.NewAddress to be varargs and demonstated that most callers of NewAddresses were used to get a slice of addresses so they could pass them to unit.SetAddresses. By making SetAddresses vararg NewAddresses is unneeded. This will be next change. https://code.launchpad.net/~dave-cheney/juju-core/108-set-addresses-take-varargs/+merge/213393 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : unit.SetAddress now takes a vararg #

Patch Set 3 : unit.SetAddress now takes a vararg #

Patch Set 4 : unit.SetAddress now takes a vararg #

Patch Set 5 : unit.SetAddress now takes a vararg #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -65 lines)			Patch
A	[revision details]	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/juju/scp_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	cmd/juju/ssh_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	cmd/juju/status_test.go	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	cmd/jujud/machine_test.go	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	juju/testing/utils.go	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	state/api/deployer/deployer_test.go	View		2 chunks	+2 lines, -5 lines	0 comments	Download
M	state/api/machiner/machiner_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	state/api/provisioner/provisioner_test.go	View	1 2	2 chunks	+2 lines, -4 lines	0 comments	Download
M	state/apiserver/client/client_test.go	View		4 chunks	+6 lines, -6 lines	0 comments	Download
M	state/apiserver/client/run_test.go	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	state/apiserver/deployer/deployer_test.go	View		2 chunks	+2 lines, -6 lines	0 comments	Download
M	state/apiserver/uniter/uniter_test.go	View	1 2	1 chunk	+1 line, -3 lines	0 comments	Download
M	state/machine.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	state/machine_test.go	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	state/megawatcher_internal_test.go	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	state/state_test.go	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	state/unit_test.go	View	1 2 3	3 chunks	+5 lines, -7 lines	0 comments	Download
M	worker/instancepoller/machine_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	worker/instancepoller/updater.go	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	worker/provisioner/kvm-broker_test.go	View	1 2	1 chunk	+1 line, -3 lines	0 comments	Download
M	worker/provisioner/lxc-broker_test.go	View	1 2	1 chunk	+1 line, -3 lines	0 comments	Download
M	worker/provisioner/provisioner_test.go	View	1 2	1 chunk	+1 line, -3 lines	0 comments	Download
M	worker/uniter/uniter_test.go	View	1 2 3 4	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rog

On 2014/03/31 01:25:18, dfc wrote: > Please take a look. LGTM, a definite win.

10 years ago (2014-03-31 18:34:39 UTC) #2

Please take a look.

Expand All Messages | Collapse All Messages