Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(552)

Issue 8236043: Added add_unit integration to fake PyJujuAPI

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 8 months ago by jeff.pihach
Modified:
8 years, 8 months ago
Reviewers:
bcsaller, mp+156419, gary.poster
Visibility:
Public.

Description

Added add_unit integration to fake PyJujuAPI add_unit integration for the fake backend of PyJujuAPI is completed with unit and integration tests using the same methods as the UI. https://code.launchpad.net/~hatch/juju-gui/add-unit/+merge/156419 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 6

Patch Set 2 : Added add_unit integration to fake PyJujuAPI #

Total comments: 1

Patch Set 3 : Added add_unit integration to fake PyJujuAPI #

Total comments: 1

Patch Set 4 : Added add_unit integration to fake PyJujuAPI #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -0 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M app/store/env/sandbox.js View 1 1 chunk +20 lines, -0 lines 0 comments Download
M test/test_sandbox.js View 1 2 1 chunk +76 lines, -0 lines 0 comments Download

Messages

Total messages: 10
jeff.pihach
Please take a look.
8 years, 8 months ago (2013-04-01 20:56:11 UTC) #1
gary.poster
On the right track. Thank you. https://codereview.appspot.com/8236043/diff/1/app/store/env/sandbox.js File app/store/env/sandbox.js (right): https://codereview.appspot.com/8236043/diff/1/app/store/env/sandbox.js#newcode365 app/store/env/sandbox.js:365: var res = ...
8 years, 8 months ago (2013-04-01 21:35:22 UTC) #2
jeff.pihach
Thanks for the review - new code incoming. https://codereview.appspot.com/8236043/diff/1/app/store/env/sandbox.js File app/store/env/sandbox.js (right): https://codereview.appspot.com/8236043/diff/1/app/store/env/sandbox.js#newcode365 app/store/env/sandbox.js:365: var ...
8 years, 8 months ago (2013-04-01 22:22:35 UTC) #3
jeff.pihach
Please take a look.
8 years, 8 months ago (2013-04-01 22:33:56 UTC) #4
gary.poster
LGTM. Thank you for sticking with this, and sorry for not being clear! Gary https://codereview.appspot.com/8236043/diff/7001/test/test_sandbox.js ...
8 years, 8 months ago (2013-04-01 22:37:50 UTC) #5
jeff.pihach
Please take a look.
8 years, 8 months ago (2013-04-01 22:46:58 UTC) #6
bcsaller
LGTM though the way you call deploy in your last test is off so not ...
8 years, 8 months ago (2013-04-01 23:13:52 UTC) #7
jeff.pihach
Thanks guys for the reviews! I had copied that signature from a previous test but ...
8 years, 8 months ago (2013-04-01 23:17:02 UTC) #8
bcsaller
On 2013/04/01 23:17:02, jeff.pihach wrote: > Thanks guys for the reviews! > > I had ...
8 years, 8 months ago (2013-04-01 23:20:48 UTC) #9
jeff.pihach
8 years, 8 months ago (2013-04-01 23:21:44 UTC) #10
*** Submitted:

Added add_unit integration to fake PyJujuAPI

add_unit integration for the fake backend of PyJujuAPI
is completed with unit and integration tests using the
same methods as the UI.

R=gary.poster, bcsaller
CC=
https://codereview.appspot.com/8236043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b