Added add_unit integration to fake PyJujuAPI

Added add_unit integration to fake PyJujuAPI

add_unit integration for the fake backend of PyJujuAPI
is completed with unit and integration tests using the
same methods as the UI.

https://code.launchpad.net/~hatch/juju-gui/add-unit/+merge/156419

(do not edit description out of merge proposal)

[jeff.pihach, 2013-04-01 20:56:11]

Please take a look.

[gary.poster, 2013-04-01 21:35:22]

On the right track.  Thank you.

https://codereview.appspot.com/8236043/diff/1/app/store/env/sandbox.js
File app/store/env/sandbox.js (right):

https://codereview.appspot.com/8236043/diff/1/app/store/env/sandbox.js#newcod...
app/store/env/sandbox.js:365: var res =
this.get('state').addUnit(data.service_name, data.num_units);
Something like this.

if (res.error) {
  data.err = res.error;
} else {
  data.result = Y.Array.map(
    res.units, function(u) {return u.id});
}

https://codereview.appspot.com/8236043/diff/1/app/store/env/sandbox.js#newcod...
app/store/env/sandbox.js:366: data.response = res;
Not this. :-)

https://codereview.appspot.com/8236043/diff/1/test/test_sandbox.js
File test/test_sandbox.js (right):

https://codereview.appspot.com/8236043/diff/1/test/test_sandbox.js#newcode531
test/test_sandbox.js:531: client.onmessage = function(received) {
You can verify that the result is a list of ids (see app/views/service.js in
_addUnitCallback).  Nice but not necessary to show that they are the right ids.

It would be nice to also have a separate test showing that you properly create
an err when there is an error.  Pass an invalid number of units or reference a
service that does not exist.

https://codereview.appspot.com/8236043/diff/1/test/test_sandbox.js#newcode545
test/test_sandbox.js:545: env.add_unit('kumquat', 2, function(data) {
Good test. You could look at the data here also, but that's probably overkill.

[jeff.pihach, 2013-04-01 22:22:35]

Thanks for the review - new code incoming.

https://codereview.appspot.com/8236043/diff/1/app/store/env/sandbox.js
File app/store/env/sandbox.js (right):

https://codereview.appspot.com/8236043/diff/1/app/store/env/sandbox.js#newcod...
app/store/env/sandbox.js:365: var res =
this.get('state').addUnit(data.service_name, data.num_units);
updated.

https://codereview.appspot.com/8236043/diff/1/test/test_sandbox.js
File test/test_sandbox.js (right):

https://codereview.appspot.com/8236043/diff/1/test/test_sandbox.js#newcode531
test/test_sandbox.js:531: client.onmessage = function(received) {
Updated the test to check for a valid object and added err test.

[jeff.pihach, 2013-04-01 22:33:56]

Please take a look.

[gary.poster, 2013-04-01 22:37:50]

LGTM.  Thank you for sticking with this, and sorry for not being clear!

Gary

https://codereview.appspot.com/8236043/diff/7001/test/test_sandbox.js
File test/test_sandbox.js (right):

https://codereview.appspot.com/8236043/diff/7001/test/test_sandbox.js#newcode531
test/test_sandbox.js:531: client.onmessage = function(received) {
assert.isUndefined(received.err)
?

[jeff.pihach, 2013-04-01 22:46:58]

Please take a look.

[bcsaller, 2013-04-01 23:13:52]

LGTM though the way you call deploy in your last test is off so not sure what
behavior your getting there.

https://codereview.appspot.com/8236043/diff/12001/test/test_sandbox.js
File test/test_sandbox.js (right):

https://codereview.appspot.com/8236043/diff/12001/test/test_sandbox.js#newcod...
test/test_sandbox.js:590: 'cs:wordpress', 'kumquat', {llama: 'pajama'}, null, 1,
callback);
What signature for deploy is this?

[jeff.pihach, 2013-04-01 23:17:02]

Thanks guys for the reviews!

I had copied that signature from a previous test but it looks like it lines up
with the deploy method in python.js ln227

[bcsaller, 2013-04-01 23:20:48]

On 2013/04/01 23:17:02, jeff.pihach wrote:
> Thanks guys for the reviews!
> 
> I had copied that signature from a previous test but it looks like it lines up
> with the deploy method in python.js ln227

ahh, fakebackend has a different signature.

[jeff.pihach, 2013-04-01 23:21:44]

*** Submitted:

Added add_unit integration to fake PyJujuAPI

add_unit integration for the fake backend of PyJujuAPI
is completed with unit and integration tests using the
same methods as the UI.

R=gary.poster, bcsaller
CC=
https://codereview.appspot.com/8236043