Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(739)

Issue 821045: code review 821045: release 2010-03-30 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by adg
Modified:
12 years, 8 months ago
Reviewers:
CC:
rsc, gri, golang-dev
Visibility:
Public.

Description

release 2010-03-30

Patch Set 1 #

Patch Set 2 : code review 821045: release 2010-03-30 #

Total comments: 2

Patch Set 3 : code review 821045: release 2010-03-30 #

Patch Set 4 : code review 821045: release 2010-03-30 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -1 line) Patch
M .hgtags View 1 chunk +0 lines, -1 line 0 comments Download
M doc/devel/release.html View 1 2 1 chunk +62 lines, -0 lines 0 comments Download

Messages

Total messages: 8
adg
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
12 years, 8 months ago (2010-03-31 00:15:32 UTC) #1
gri
FYI. - Robert http://codereview.appspot.com/821045/diff/2001/3002 File doc/devel/release.html (right): http://codereview.appspot.com/821045/diff/2001/3002#newcode18 doc/devel/release.html:18: The return values are not copied ...
12 years, 8 months ago (2010-03-31 00:22:26 UTC) #2
rsc
s/are not copied/are copied/
12 years, 8 months ago (2010-03-31 00:28:12 UTC) #3
adg
Hello rsc, gri (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 8 months ago (2010-03-31 00:28:55 UTC) #4
rsc1
LGTM
12 years, 8 months ago (2010-03-31 00:31:07 UTC) #5
gri
LGTM. Perhaps line 18 and 19 should just go away? It's almost an implementation detail. ...
12 years, 8 months ago (2010-03-31 00:36:35 UTC) #6
rsc
I think it's an important point, because it's a change. Rewording: Deferred functions run before ...
12 years, 8 months ago (2010-03-31 00:40:41 UTC) #7
adg
12 years, 8 months ago (2010-03-31 00:41:03 UTC) #8
*** Submitted as http://code.google.com/p/go/source/detail?r=57380d620ee6 ***

release 2010-03-30

R=rsc, gri
CC=golang-dev
http://codereview.appspot.com/821045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b