code review 821045: release 2010-03-30

release 2010-03-30

[adg, 2010-03-31 00:15:32]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[gri, 2010-03-31 00:22:26]

FYI.
- Robert

http://codereview.appspot.com/821045/diff/2001/3002
File doc/devel/release.html (right):

http://codereview.appspot.com/821045/diff/2001/3002#newcode18
doc/devel/release.html:18: The return values are not copied back to the caller
only after deferred
I can't parse this sentence.

http://codereview.appspot.com/821045/diff/2001/3002#newcode24
doc/devel/release.html:24: In a related change, panicln is gone.  Panic and
recover are recognized by the
Also: panic is now a one-argument function. Not sure if that's already in this
release.

[rsc, 2010-03-31 00:28:12]

s/are not copied/are copied/

[adg, 2010-03-31 00:28:55]

Hello rsc, gri (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc1, 2010-03-31 00:31:07]

LGTM

[gri, 2010-03-31 00:36:35]

LGTM.

Perhaps line 18 and 19 should just go away? It's almost an implementation
detail. As it stands, one could interpret them as return values are not
copied back if there are no deferred functions.

- Robert

On Tue, Mar 30, 2010 at 5:28 PM, <adg@golang.org> wrote:

> Hello rsc, gri (cc: golang-dev@googlegroups.com),
>
> Please take another look.
>
>
>
> http://codereview.appspot.com/821045/show
>

[rsc, 2010-03-31 00:40:41]

I think it's an important point, because it's a change.
Rewording:

Deferred functions run before the return values are copied back to the caller.

[adg, 2010-03-31 00:41:03]

*** Submitted as http://code.google.com/p/go/source/detail?r=57380d620ee6 ***

release 2010-03-30

R=rsc, gri
CC=golang-dev
http://codereview.appspot.com/821045