Issue 8191044: code review 8191044: net/http: fix incredibly racy TestTransportReading100Co...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8191044: code review 8191044: net/http: fix incredibly racy TestTransportReading100Co... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by bradfitz

Modified:
12 years, 1 month ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

net/http: fix incredibly racy TestTransportReading100Continue Whoops. I'm surprised it even worked before. (Need two pipes, not one.) Also, remove the whole pipe registration business, since it wasn't even required in the previous version. (I'd later fixed it at the end of send100Response, but forgot to delete it)

Patch Set 1 #

Patch Set 2 : diff -r 633e8f7f61b7 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 633e8f7f61b7 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 63a5dca37edc https://go.googlecode.com/hg/ #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -22 lines)			Patch
	M	src/pkg/net/http/transport_test.go	View	1	2 chunks	+5 lines, -22 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 1 month ago (2013-03-30 18:03:47 UTC) #1

bradfitz

12 years, 1 month ago (2013-03-30 18:18:59 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=946f0a049860 ***

net/http: fix incredibly racy TestTransportReading100Continue

Whoops. I'm surprised it even worked before. (Need two pipes,
not one.)

Also, remove the whole pipe registration business, since it
wasn't even required in the previous version. (I'd later fixed
it at the end of send100Response, but forgot to delete it)

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/8191044

Expand All Messages | Collapse All Messages