Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(245)

Issue 8186045: Add an extension for managing overlay indicators

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 8 months ago by rharding
Modified:
8 years, 8 months ago
Reviewers:
jeff.pihach, mp+156280
Visibility:
Public.

Description

Add an extension for managing overlay indicators - Add an extension used in views that use an overlay indicator - Tracks instances, makes sure they're not duplicated - Makes sure on the view/objects destroy it cleans out the indicator instances. - Add tests to verify it does the job of preventing dupes and destroying. https://code.launchpad.net/~rharding/juju-gui/indicator_manager/+merge/156280 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add an extension for managing overlay indicators #

Patch Set 3 : Add an extension for managing overlay indicators #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -45 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M app/subapps/browser/views/charm.js View 3 chunks +3 lines, -44 lines 0 comments Download
M app/widgets/overlay-indicator.js View 1 chunk +78 lines, -0 lines 0 comments Download
M test/test_overlay_indicator.js View 2 chunks +48 lines, -1 line 0 comments Download

Messages

Total messages: 7
rharding
Please take a look.
8 years, 8 months ago (2013-03-30 20:30:05 UTC) #1
rharding
On 2013/03/30 20:30:05, rharding wrote: > Please take a look. Jeff brought up that "my ...
8 years, 8 months ago (2013-04-01 11:40:21 UTC) #2
j.c.sackett
Rick, one comment in the diff, and a question about your worst case. > If ...
8 years, 8 months ago (2013-04-01 12:36:12 UTC) #3
rharding
On 2013/04/01 12:36:12, j.c.sackett wrote: > Rick, one comment in the diff, and a question ...
8 years, 8 months ago (2013-04-01 12:39:49 UTC) #4
j.c.sackett
On 2013/04/01 12:39:49, rharding wrote: > I'm still looking into it myself. I wasn't aware ...
8 years, 8 months ago (2013-04-01 12:45:22 UTC) #5
jeff.pihach
LGTM go....extensions!
8 years, 8 months ago (2013-04-01 14:20:59 UTC) #6
rharding
8 years, 8 months ago (2013-04-01 15:04:57 UTC) #7
*** Submitted:

Add an extension for managing overlay indicators

- Add an extension used in views that use an overlay indicator
- Tracks instances, makes sure they're not duplicated
- Makes sure on the view/objects destroy it cleans out the indicator
instances.
- Add tests to verify it does the job of preventing dupes and destroying.

R=j.c.sackett, jeff.pihach
CC=
https://codereview.appspot.com/8186045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b