Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(110)

Issue 8182043: code review 8182043: cmd/gc, cmd/ld: fix warnings on Plan 9 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years ago by 0intro
Modified:
13 years ago
Reviewers:
CC:
dave_cheney.net, golang-dev, lucio, remyoudompheng, bradfitz
Visibility:
Public.

Description

cmd/gc, cmd/ld: fix warnings on Plan 9 src/cmd/gc/closure.c:133 param declared and not used: nowrap src/cmd/gc/const.c:1139 set and not used: t1 src/cmd/ld/data.c:652 format mismatch #llx INT, arg 7 src/cmd/ld/data.c:652 format mismatch #llx INT, arg 8 src/cmd/ld/data.c:1230 set and not used: datsize

Patch Set 1 #

Patch Set 2 : diff -r 192e257c6507 https://code.google.com/p/go #

Patch Set 3 : diff -r 192e257c6507 https://code.google.com/p/go #

Patch Set 4 : diff -r 5260abd6df41 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M src/cmd/gc/closure.c View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/cmd/gc/const.c View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/cmd/ld/data.c View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 12
0intro
Hello golang-dev (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
13 years ago (2013-03-29 23:04:55 UTC) #1
dave_cheney.net
I'd like to ask Remy to take a look at this one.
13 years ago (2013-03-30 00:44:18 UTC) #2
remyoudompheng
LGTM What compiler produced the errors?
13 years ago (2013-03-30 08:44:08 UTC) #3
0intro
> What compiler produced the errors? The Plan 9 compiler produced these warnings: src/cmd/gc/closure.c:133 param ...
13 years ago (2013-03-30 10:00:14 UTC) #4
lucio
It also picked up two format mismatches in ld/data.c:652 (#llx/INT, args 7 and 8). May ...
13 years ago (2013-03-30 12:54:05 UTC) #5
0intro
> It also picked up two format mismatches in ld/data.c:652 (#llx/INT, > args 7 and ...
13 years ago (2013-03-30 13:13:19 UTC) #6
0intro
Hello dave@cheney.net, golang-dev, golang-dev@googlegroups.com, lucio.dere@gmail.com, remyoudompheng@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
13 years ago (2013-03-30 13:14:18 UTC) #7
lucio
I guess I'm looking a gift horse in the mouth here, but should you not ...
13 years ago (2013-03-30 13:44:43 UTC) #8
0intro
> I guess I'm looking a gift horse in the mouth here, but should you ...
13 years ago (2013-03-30 13:50:32 UTC) #9
lucio
I do apologise, I wasn't expecting that. Lucio. On 3/30/13, 0intro@gmail.com <0intro@gmail.com> wrote: >> I ...
13 years ago (2013-03-30 14:22:43 UTC) #10
bradfitz
LGTM On Sat, Mar 30, 2013 at 6:50 AM, <0intro@gmail.com> wrote: > I guess I'm ...
13 years ago (2013-03-30 16:44:42 UTC) #11
bradfitz
13 years ago (2013-03-30 16:44:55 UTC) #12
*** Submitted as https://code.google.com/p/go/source/detail?r=b033e458647e ***

cmd/gc, cmd/ld: fix warnings on Plan 9

src/cmd/gc/closure.c:133 param declared and not used: nowrap
src/cmd/gc/const.c:1139 set and not used: t1
src/cmd/ld/data.c:652 format mismatch #llx INT, arg 7
src/cmd/ld/data.c:652 format mismatch #llx INT, arg 8
src/cmd/ld/data.c:1230 set and not used: datsize

R=dave, golang-dev, lucio.dere, remyoudompheng, bradfitz
CC=golang-dev
https://codereview.appspot.com/8182043

Committer: Brad Fitzpatrick <bradfitz@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b