Issue 81720043: Fix lp 1298703

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 81720043: Fix lp 1298703

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 1 month ago by dave

Modified:
10 years, 1 month ago

Reviewers:
mp+213195, axw

Visibility:
Public.

Description

Fix lp 1298703 One failure was a simple list ordering bug. The other two more complicated. NewAddress always returns an address with the scope of NetworkUnknown. In that case the results from calling unit.Public/PrivateAddress were essentially random. It feels like there are some other footguns in this area. Should NewAddress/NewAddresses create NetworkUnknown Address values ? What happens if they leak into the state and back to the client? How many other places are these things leaking into. I'd like to explore removing NewAddress/NewAddresses in a followup, if they are used only for testing (axw), then they are doing us a disservice. Thanks to Ian and Andrew for their assistance https://code.launchpad.net/~dave-cheney/juju-core/104-fix-lp-1298703/+merge/213195 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -9 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/machine_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	state/unit_test.go	View	2 chunks	+14 lines, -8 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

axw

10 years, 1 month ago (2014-03-28 04:50:25 UTC) #2

On 2014/03/28 04:42:14, dfc wrote:
> Please take a look.

LGTM

+1 to moving NewAddress(es)

There is one non-test place where NewAddress is used, and in that case it
legitimately does not know the address's scope. It would be good to make that
explicit anyhow.

Expand All Messages | Collapse All Messages