Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(280)

Issue 8171047: Add support for loading QA data into charm detail

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 8 months ago by rharding
Modified:
8 years, 8 months ago
Reviewers:
mp+156392, j.c.sackett, jeff.pihach
Visibility:
Public.

Description

Add support for loading QA data into charm detail - Update the store with the api call to the /qa. - Add support to the charm detail view to load qa data when the Quality tab is selected. - Add code to summarize the scoring for the template to make life easy for it. - Add tests for the scoring summary and clicking the quality tab. https://code.launchpad.net/~rharding/juju-gui/qa_tab/+merge/156392 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 6

Patch Set 2 : Add support for loading QA data into charm detail #

Total comments: 6

Patch Set 3 : Add support for loading QA data into charm detail #

Patch Set 4 : Add support for loading QA data into charm detail #

Unified diffs Side-by-side diffs Delta from patch set Stats (+525 lines, -7 lines) Patch
A [revision details] View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M app/store/charm.js View 3 chunks +20 lines, -2 lines 0 comments Download
M app/subapps/browser/templates/browser_charm.handlebars View 1 chunk +5 lines, -5 lines 0 comments Download
A app/subapps/browser/templates/browser_qa.handlebars View 1 2 1 chunk +17 lines, -0 lines 0 comments Download
M app/subapps/browser/views/charm.js View 1 6 chunks +102 lines, -0 lines 0 comments Download
A test/data/qa.json View 1 1 chunk +339 lines, -0 lines 0 comments Download
M test/test_browser_charm_details.js View 1 2 3 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 9
rharding
Please take a look.
8 years, 8 months ago (2013-04-01 19:34:39 UTC) #1
jeff.pihach
LGTM Thanks - with trivial. https://codereview.appspot.com/8171047/diff/1/app/subapps/browser/templates/browser_qa.handlebars File app/subapps/browser/templates/browser_qa.handlebars (right): https://codereview.appspot.com/8171047/diff/1/app/subapps/browser/templates/browser_qa.handlebars#newcode7 app/subapps/browser/templates/browser_qa.handlebars:7: <h3>{{this.description}} <span class="heading_notes">{{this.score}}/{{this.questions.length}} points</span></h3> ...
8 years, 8 months ago (2013-04-01 19:49:23 UTC) #2
rharding
Please take a look. https://codereview.appspot.com/8171047/diff/1/app/subapps/browser/templates/browser_qa.handlebars File app/subapps/browser/templates/browser_qa.handlebars (right): https://codereview.appspot.com/8171047/diff/1/app/subapps/browser/templates/browser_qa.handlebars#newcode7 app/subapps/browser/templates/browser_qa.handlebars:7: <h3>{{this.description}} <span class="heading_notes">{{this.score}}/{{this.questions.length}} points</span></h3> On ...
8 years, 8 months ago (2013-04-01 20:06:51 UTC) #3
rharding
Comments below, updated code coming. https://codereview.appspot.com/8171047/diff/1/test/data/qa.json File test/data/qa.json (right): https://codereview.appspot.com/8171047/diff/1/test/data/qa.json#newcode1 test/data/qa.json:1: { On 2013/04/01 19:49:23, ...
8 years, 8 months ago (2013-04-01 20:08:25 UTC) #4
j.c.sackett
Looks good, some questions below. https://codereview.appspot.com/8171047/diff/2002/app/subapps/browser/templates/browser_qa.handlebars File app/subapps/browser/templates/browser_qa.handlebars (right): https://codereview.appspot.com/8171047/diff/2002/app/subapps/browser/templates/browser_qa.handlebars#newcode7 app/subapps/browser/templates/browser_qa.handlebars:7: <h3>{{this.description}} <span class="heading_notes">{{this.score}}/{{this.questions.length}} points</span></h3> ...
8 years, 8 months ago (2013-04-01 20:57:39 UTC) #5
rharding
Comments replied to. Updated code coming next. https://codereview.appspot.com/8171047/diff/2002/app/subapps/browser/templates/browser_qa.handlebars File app/subapps/browser/templates/browser_qa.handlebars (right): https://codereview.appspot.com/8171047/diff/2002/app/subapps/browser/templates/browser_qa.handlebars#newcode7 app/subapps/browser/templates/browser_qa.handlebars:7: <h3>{{this.description}} <span ...
8 years, 8 months ago (2013-04-01 23:27:25 UTC) #6
rharding
Please take a look.
8 years, 8 months ago (2013-04-01 23:29:43 UTC) #7
j.c.sackett
LGTM. As to the always passing assert, I would just ask that you put a ...
8 years, 8 months ago (2013-04-02 14:32:40 UTC) #8
rharding
8 years, 8 months ago (2013-04-02 15:59:17 UTC) #9
*** Submitted:

Add support for loading QA data into charm detail

- Update the store with the api call to the /qa.
- Add support to the charm detail view to load qa data when the Quality tab is
selected.
- Add code to summarize the scoring for the template to make life easy for it.
- Add tests for the scoring summary and clicking the quality tab.

R=jeff.pihach, j.c.sackett
CC=
https://codereview.appspot.com/8171047
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b