Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(78)

Issue 8165044: code review 8165044: runtime: some addition map benchmarks (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 4 months ago by bradfitz
Modified:
9 years, 4 months ago
Reviewers:
khr1
CC:
khr, r, golang-dev
Visibility:
Public.

Description

runtime: additional map benchmarks for repeated lookups For the future. Update Issue 5147

Patch Set 1 #

Patch Set 2 : diff -r 7b47ca7337ca https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 7b47ca7337ca https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 92913ac2c60f https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M src/pkg/runtime/mapspeed_test.go View 1 2 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 4
bradfitz
Hello khr@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
9 years, 4 months ago (2013-03-29 20:20:39 UTC) #1
r
LGTM
9 years, 4 months ago (2013-03-29 20:47:25 UTC) #2
bradfitz
*** Submitted as https://code.google.com/p/go/source/detail?r=8ad148b318d0 *** runtime: additional map benchmarks for repeated lookups For the future. ...
9 years, 4 months ago (2013-03-29 20:50:47 UTC) #3
khr1
9 years, 4 months ago (2013-03-29 21:53:14 UTC) #4
LGTM


On Fri, Mar 29, 2013 at 1:50 PM, <bradfitz@golang.org> wrote:

> *** Submitted as
>
https://code.google.com/p/go/**source/detail?r=8ad148b318d0<https://code.goog...
>
> runtime: additional map benchmarks for repeated lookups
>
>
> For the future.
>
> Update Issue 5147
>
> R=khr, r
> CC=golang-dev
>
https://codereview.appspot.**com/8165044<https://codereview.appspot.com/8165044>
>
>
>
https://codereview.appspot.**com/8165044/<https://codereview.appspot.com/8165...
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b