Issue 8165044: code review 8165044: runtime: some addition map benchmarks

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8165044: code review 8165044: runtime: some addition map benchmarks (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by bradfitz

Modified:
11 years ago

Reviewers:
khr1

CC:
khr, r, golang-dev

Visibility:
Public.

Description

runtime: additional map benchmarks for repeated lookups For the future. Update Issue 5147

Patch Set 1 #

Patch Set 2 : diff -r 7b47ca7337ca https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 7b47ca7337ca https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 92913ac2c60f https://go.googlecode.com/hg/ #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -0 lines)			Patch
	M	src/pkg/runtime/mapspeed_test.go	View	1	2 chunks	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bradfitz

Hello khr@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

11 years ago (2013-03-29 20:20:39 UTC) #1

bradfitz

*** Submitted as https://code.google.com/p/go/source/detail?r=8ad148b318d0 *** runtime: additional map benchmarks for repeated lookups For the future. ...

11 years ago (2013-03-29 20:50:47 UTC) #3

khr1

11 years ago (2013-03-29 21:53:14 UTC) #4

LGTM


On Fri, Mar 29, 2013 at 1:50 PM, <bradfitz@golang.org> wrote:

> *** Submitted as
>
https://code.google.com/p/go/**source/detail?r=8ad148b318d0<https://code.goog...
>
> runtime: additional map benchmarks for repeated lookups
>
>
> For the future.
>
> Update Issue 5147
>
> R=khr, r
> CC=golang-dev
>
https://codereview.appspot.**com/8165044<https://codereview.appspot.com/8165044>
>
>
>
https://codereview.appspot.**com/8165044/<https://codereview.appspot.com/8165...
>

Expand All Messages | Collapse All Messages