Fix add_relation in the Go env.

Fix add_relation in the Go env.

Tweak add_relation in the Go environment code to fit with
what juju-core returns.

https://code.launchpad.net/~teknico/juju-gui/tweak-add-rel-in-go-env/+merge/156196

(do not edit description out of merge proposal)

[teknico, 2013-03-29 17:43:39]

Please take a look.

[gary.poster, 2013-03-29 20:04:10]

LGTM with suggested but optional changes.

Thank you for figuring this out!  The research you did for this actually answers
some concerns I had about the delta stream, so it was very timely to see this.
:-)

Gary

https://codereview.appspot.com/8162043/diff/1/app/store/env/go.js
File app/store/env/go.js (right):

https://codereview.appspot.com/8162043/diff/1/app/store/env/go.js#newcode718
app/store/env/go.js:718: if (response !== undefined) {
I think

if (response) {...}

is entirely appropriate and idiomatic here, myself.

https://codereview.appspot.com/8162043/diff/1/app/store/env/go.js#newcode726
app/store/env/go.js:726: epGuiB[svcNameB] = {'name': epJujuB.Name};
When I do this kind of thing I sometimes iterate.  The following is intended to
replace all of the newly added changed section (lines 716-734).

var result = {};
var response = data.Response;
if (response) {
  result.endpoints = [];
  Y.each([endpoint_a, endpoint_b], function(endpointName) {
    var endpoint = response.Endpoints[endpointName];
    var serviceName = endpointName.split(':')[0];
    var guiEndpoint = {};
    guiEndpoint[serviceName] = {name: endpoint.Name}
    result.endpoints.push(guiEndpoint);
  });
  result.id = endpoint_a + '-' + endpoint_b;
  // The interface and scope should be the same for both endpoints.
  result.interface = result.endpoints[0].Interface;
  result.scope = result.endpoints[0].Scope;
}

[jeff.pihach, 2013-03-30 18:00:38]

LGTM Thanks for putting this together

[teknico, 2013-04-02 11:52:38]

I also moved to use simple service names ('mysql') as keys in messages to/from
juju-core rather than endpoint names ('mysql:server').

https://codereview.appspot.com/8162043/diff/1/app/store/env/go.js
File app/store/env/go.js (right):

https://codereview.appspot.com/8162043/diff/1/app/store/env/go.js#newcode718
app/store/env/go.js:718: if (response !== undefined) {
gary.poster wrote:
> I think
> 
> if (response) {...}
> 
> is entirely appropriate and idiomatic here, myself.

Done. (I wrote it that way earlier, than unnecessarily changed it. Thanks.)

https://codereview.appspot.com/8162043/diff/1/app/store/env/go.js#newcode726
app/store/env/go.js:726: epGuiB[svcNameB] = {'name': epJujuB.Name};
gary.poster wrote:
> When I do this kind of thing I sometimes iterate.  The following
> is intended to replace all of the newly added changed section
> (lines 716-734).
> ...

Done. Well, for just two elements it might not be mandatory, but still nice.

[teknico, 2013-04-02 11:54:39]

Please take a look.

[teknico, 2013-04-02 12:03:27]

*** Submitted:

Fix add_relation in the Go env.

Tweak add_relation in the Go environment code to fit with
what juju-core returns.

R=gary.poster, jeff.pihach
CC=
https://codereview.appspot.com/8162043