Issue 8158043: Refactor to match go - entityName to tag

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8158043: Refactor to match go - entityName to tag

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by matthew.scott

Modified:
11 years, 1 month ago

Reviewers:
jeff.pihach, gary.poster, mp+156188

Visibility:
Public.

Description

Refactor to match go - entityName to tag https://code.launchpad.net/~makyo/juju-gui/entity-tag-refactor/+merge/156188 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Refactor to match go - entityName to tag #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -10 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/store/env/go.js	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	test/test_env_go.js	View		6 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

gary.poster

LGTM. EntityName! EntityId! Tag! AuthTag! Hut, hut! Thank you Gary

11 years, 1 month ago (2013-03-29 16:29:03 UTC) #2

matthew.scott

11 years, 1 month ago (2013-04-01 14:47:58 UTC) #4

*** Submitted:

Refactor to match go - entityName to tag

R=gary.poster, jeff.pihach
CC=
https://codereview.appspot.com/8158043

Expand All Messages | Collapse All Messages