Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(495)

Issue 81550043: code review 81550043: go.tools/godoc: fix two regressions caused by -analysis CL. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by adonovan
Modified:
11 years, 7 months ago
Reviewers:
bgarcia
CC:
crawshaw1, bgarcia, golang-codereviews
Visibility:
Public.

Description

go.tools/godoc: fix two regressions caused by -analysis CL. - Add missing methodset.html template file. - Suppress initial display of package callgraph. Client-side JS will make it visible if there is data.

Patch Set 1 #

Patch Set 2 : diff -r 1628982cbb60 https://code.google.com/p/go.tools #

Patch Set 3 : diff -r 1628982cbb60 https://code.google.com/p/go.tools #

Patch Set 4 : diff -r 1628982cbb60 https://code.google.com/p/go.tools #

Unified diffs Side-by-side diffs Delta from patch set Stats (+430 lines, -417 lines) Patch
M godoc/static/godocs.js View 1 chunk +2 lines, -0 lines 0 comments Download
A godoc/static/methodset.html View 1 chunk +9 lines, -0 lines 0 comments Download
M godoc/static/package.html View 1 chunk +1 line, -1 line 0 comments Download
M godoc/static/static.go View 5 chunks +418 lines, -416 lines 0 comments Download

Messages

Total messages: 4
adonovan
Hello crawshaw@google.com, bgarcia@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools
11 years, 7 months ago (2014-03-27 19:15:13 UTC) #1
bgarcia
LGTM. It looks like most of the changes in static.go was a reordering of items. ...
11 years, 7 months ago (2014-03-27 19:23:31 UTC) #2
adonovan
On 2014/03/27 19:23:31, bgarcia wrote: > LGTM. > It looks like most of the changes ...
11 years, 7 months ago (2014-03-27 19:29:15 UTC) #3
adonovan
11 years, 7 months ago (2014-03-27 19:30:16 UTC) #4
*** Submitted as
https://code.google.com/p/go/source/detail?r=76cd3f87a9ba&repo=tools ***

go.tools/godoc: fix two regressions caused by -analysis CL.

- Add missing methodset.html template file.
- Suppress initial display of package callgraph.
  Client-side JS will make it visible if there is data.

LGTM=bgarcia
R=crawshaw, bgarcia
CC=golang-codereviews
https://codereview.appspot.com/81550043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b