code review 81530043: bytes, strings: allow Reader.Seek past 1<<31

bytes, strings: allow Reader.Seek past 1<<31

Fixes Issue 7654

[bradfitz, 2014-03-27 18:46:33]

Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[kortschak, 2014-03-27 19:36:22]

How about just changing the condition to:

if abs != int64(int(abs)) {

https://codereview.appspot.com/81530043/diff/40001/src/pkg/bytes/reader_test.go
File src/pkg/bytes/reader_test.go (right):

https://codereview.appspot.com/81530043/diff/40001/src/pkg/bytes/reader_test....
src/pkg/bytes/reader_test.go:30: {seek: os.SEEK_SET, off: 1 << 33, wantpos: 1 <<
33},
What about 386?

[kortschak, 2014-03-27 19:44:53]

Sorry, I didn't realise this discussion had already been had.

[bradfitz, 2014-03-28 18:07:19]

Dan, feel free to review if you're interested.



On Thu, Mar 27, 2014 at 12:44 PM, <dan.kortschak@adelaide.edu.au> wrote:

> Sorry, I didn't realise this discussion had already been had.
>
> https://codereview.appspot.com/81530043/
>

[rsc, 2014-03-28 18:32:12]

LGTM

[bradfitz, 2014-03-28 19:23:55]

*** Submitted as https://code.google.com/p/go/source/detail?r=d1c3ecb12cbf ***

bytes, strings: allow Reader.Seek past 1<<31

Fixes Issue 7654

LGTM=rsc
R=rsc, dan.kortschak
CC=golang-codereviews
https://codereview.appspot.com/81530043

[gobot, 2014-03-28 19:57:28]

This CL appears to have broken the darwin-amd64-race-cheney builder.
See http://build.golang.org/log/62d0554cff0a7093a537572489569110b2ce11e6