Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(195)

Issue 815042: cross platform failure and silly test in doctest

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 1 month ago by techtonik
Modified:
13 years, 5 months ago
Reviewers:
merwok
Base URL:
http://svn.python.org/projects/python/trunk/
Visibility:
Public.

Description

http://bugs.python.org/issue6703

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -11 lines) Patch
Doc/library/doctest.rst View 1 chunk +3 lines, -3 lines 0 comments Download
Lib/doctest.py View 2 chunks +8 lines, -6 lines 2 comments Download
Lib/test/test_doctest.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2
techtonik
14 years, 1 month ago (2010-04-01 14:12:22 UTC) #1
merwok
13 years, 5 months ago (2010-11-30 05:32:40 UTC) #2
Sensible changes.

http://codereview.appspot.com/815042/diff/1/Lib/doctest.py
File Lib/doctest.py (right):

http://codereview.appspot.com/815042/diff/1/Lib/doctest.py#newcode363
Lib/doctest.py:363: raise ValueError('Absolute path specified as
module-relative' +
You missed a space at the end of the line.

You can rely on implicit string concatenation instead of using +.

http://codereview.appspot.com/815042/diff/1/Lib/doctest.py#newcode364
Lib/doctest.py:364: 'path: ' + path)
Is it possible that path is not a string?  If so, this error message would blow
up.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b