Issue 815042: cross platform failure and silly test in doctest

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 815042: cross platform failure and silly test in doctest

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by techtonik

Modified:
13 years, 4 months ago

Reviewers:
merwok

Base URL:
http://svn.python.org/projects/python/trunk/

Visibility:
Public.

Description

http://bugs.python.org/issue6703

Patch Set 1 #

Total comments: 2

Downloaded from: http://bugs.python.org/file16722/6703.silly.abspath.test.diff

Created: 14 years ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+13 lines, -11 lines)			Patch
Doc/library/doctest.rst	View	1 chunk	+3 lines, -3 lines	0 comments	Download
Lib/doctest.py	View	2 chunks	+8 lines, -6 lines	2 comments	Download
Lib/test/test_doctest.py	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

merwok

13 years, 4 months ago (2010-11-30 05:32:40 UTC) #2

Sensible changes.

http://codereview.appspot.com/815042/diff/1/Lib/doctest.py
File Lib/doctest.py (right):

http://codereview.appspot.com/815042/diff/1/Lib/doctest.py#newcode363
Lib/doctest.py:363: raise ValueError('Absolute path specified as
module-relative' +
You missed a space at the end of the line.

You can rely on implicit string concatenation instead of using +.

http://codereview.appspot.com/815042/diff/1/Lib/doctest.py#newcode364
Lib/doctest.py:364: 'path: ' + path)
Is it possible that path is not a string?  If so, this error message would blow
up.

Expand All Messages | Collapse All Messages