Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(106)

Issue 81400043: Add the distro-only flag.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 1 month ago by frankban
Modified:
10 years, 1 month ago
Reviewers:
rharding, mp+213021
Visibility:
Public.

Description

Add the distro-only flag. This can be used (e.g. in trusty) to prevent quickstart from installing the Juju stable PPA. Tests: `make check`. No QA required, I already tested this on a trusty VM. https://code.launchpad.net/~frankban/juju-quickstart/distro-only-flag/+merge/213021 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Add the distro-only flag. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -12 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M quickstart/__init__.py View 1 chunk +1 line, -1 line 0 comments Download
M quickstart/app.py View 2 chunks +13 lines, -7 lines 0 comments Download
M quickstart/manage.py View 3 chunks +5 lines, -1 line 0 comments Download
M quickstart/tests/test_app.py View 5 chunks +47 lines, -3 lines 0 comments Download

Messages

Total messages: 4
frankban
Please take a look.
10 years, 1 month ago (2014-03-27 11:09:52 UTC) #1
rharding
LGTM thanks for the quick update.
10 years, 1 month ago (2014-03-27 12:53:21 UTC) #2
frankban
*** Submitted: Add the distro-only flag. This can be used (e.g. in trusty) to prevent ...
10 years, 1 month ago (2014-03-27 12:57:06 UTC) #3
frankban
10 years, 1 month ago (2014-03-27 12:59:29 UTC) #4
Hi Rick, thanks for the review!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b