code review 8136043: testing: report test as failed if the test panics.

testing: report test as failed if the test panics.

Fixes issue 5149.

[Ewan Chou, 2013-03-29 07:57:44]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[dave_cheney.net, 2013-03-29 09:05:10]

On 2013/03/29 07:57:44, Ewan Chou wrote:
> Hello mailto:golang-dev@googlegroups.com,
> 
> I'd like you to review this change to
> https://code.google.com/p/go

A procedural nit: please place a space between the description and the "fixed
issue 5149". Also it needs to be written as "Fixes issue 5149." for the rietveld
<> codereview magic to happen.

Lastly, please make the description 

    testing: report test as failed if the test panics.

[Ewan Chou, 2013-03-30 01:47:40]

On 2013/03/29 09:05:10, dfc wrote:
> On 2013/03/29 07:57:44, Ewan Chou wrote:
> > Hello mailto:golang-dev@googlegroups.com,
> > 
> > I'd like you to review this change to
> > https://code.google.com/p/go
> 
> A procedural nit: please place a space between the description and the "fixed
> issue 5149". Also it needs to be written as "Fixes issue 5149." for the
rietveld
> <> codereview magic to happen.
> 
> Lastly, please make the description 
> 
>     testing: report test as failed if the test panics.

updated

[dave_cheney.net, 2013-03-30 05:02:23]

Thank you. This looks good to me and works as it says on the tin. 

I'd like to hear from a few other reviewers.

[minux1, 2013-03-30 11:12:36]

LGTM.

[dave_cheney.net, 2013-04-01 11:36:58]

*** Submitted as https://code.google.com/p/go/source/detail?r=0d4f63c51d56 ***

testing: report test as failed if the test panics.

Fixes issue 5149.

R=golang-dev, dave, minux.ma
CC=golang-dev
https://codereview.appspot.com/8136043

Committer: Dave Cheney <dave@cheney.net>

[khr, 2013-07-22 19:29:47]

R=close