Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(524)

Issue 8134043: code review 8134043: go/build: disable cgo when cross compiling (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 8 months ago by dfc
Modified:
3 weeks, 5 days ago
Reviewers:
jankostraka.js, bradfitz
Visibility:
Public.

Description

go/build: disable cgo when cross compiling Fixes issue 5141.

Patch Set 1 #

Patch Set 2 : diff -r 2433c3567273 https://code.google.com/p/go #

Patch Set 3 : diff -r 2433c3567273 https://code.google.com/p/go #

Patch Set 4 : diff -r c81bb3def1ef https://code.google.com/p/go #

Total comments: 2

Patch Set 5 : diff -r 282dcbf1f423 https://code.google.com/p/go #

Patch Set 6 : diff -r cfe93dfc5788 https://code.google.com/p/go #

Patch Set 7 : diff -r cfe93dfc5788 https://code.google.com/p/go #

Patch Set 8 : diff -r e8d3578a3f34 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M src/pkg/go/build/build.go View 1 2 3 4 6 7 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 17
dfc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
8 years, 8 months ago (2013-03-30 05:11:03 UTC) #1
dfc
https://codereview.appspot.com/8134043/diff/10001/src/pkg/go/build/build.go File src/pkg/go/build/build.go (right): https://codereview.appspot.com/8134043/diff/10001/src/pkg/go/build/build.go#newcode311 src/pkg/go/build/build.go:311: // amd64 to 386 but not the other way ...
8 years, 8 months ago (2013-03-30 05:12:13 UTC) #2
ality
You can only cross-compile CGO packages for linux-386 on linux-amd64 when the extra 32-bit libraries ...
8 years, 8 months ago (2013-03-30 07:01:42 UTC) #3
dfc
> For example, on Archlinux you have to enable > the multilib repository and install ...
8 years, 8 months ago (2013-03-30 07:03:12 UTC) #4
minux1
https://codereview.appspot.com/8134043/diff/10001/src/pkg/go/build/build.go File src/pkg/go/build/build.go (right): https://codereview.appspot.com/8134043/diff/10001/src/pkg/go/build/build.go#newcode306 src/pkg/go/build/build.go:306: if runtime.GOARCH == c.GOARCH && runtime.GOOS == c.GOOS { ...
8 years, 8 months ago (2013-03-30 10:51:46 UTC) #5
dfc
> i suggest we just use runtime.GOOS == c.GOOS for this test > to fix ...
8 years, 8 months ago (2013-03-31 00:47:47 UTC) #6
dfc
Hello golang-dev@googlegroups.com, minux.ma@gmail.com, ality@pbrane.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
8 years, 8 months ago (2013-03-31 00:50:46 UTC) #7
dfc
<ping />
8 years, 8 months ago (2013-04-02 04:11:51 UTC) #8
bradfitz
LGTM I wouldn't mind a message in verbose mode saying "# CGO_ENABLED not set. Defaulting ...
8 years, 8 months ago (2013-04-02 04:16:46 UTC) #9
dfc
Let me see what I can come up with. This CL isn't time sensitive so ...
8 years, 8 months ago (2013-04-02 04:19:49 UTC) #10
dfc
Please take another look. I've added the logging as requested, but because go/build doesn't have ...
8 years, 8 months ago (2013-04-03 08:08:21 UTC) #11
dfc
Hello golang-dev@googlegroups.com, minux.ma@gmail.com, ality@pbrane.org, bradfitz@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
8 years, 8 months ago (2013-04-03 08:08:40 UTC) #12
bradfitz
LGTM without the printf. I'd rather it not be noisy by default. If there are ...
8 years, 8 months ago (2013-04-03 08:11:17 UTC) #13
dfc
SGTM. Will revert to the previous patchset and submit. r/brad - should I add a ...
8 years, 8 months ago (2013-04-03 08:12:15 UTC) #14
dfc
*** Submitted as https://code.google.com/p/go/source/detail?r=139b5fe32880 *** go/build: disable cgo when cross compiling Fixes issue 5141. R=golang-dev, ...
8 years, 8 months ago (2013-04-03 08:13:50 UTC) #15
PattyStackzz
de2fcae372bd4b06b684380ea6b55100683e433a
5 months, 1 week ago (2021-06-22 23:22:21 UTC) #16
jstraka27
3 weeks, 5 days ago (2021-11-01 19:51:59 UTC) #17
Message was sent while issue was closed.

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b