Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(688)

Issue 8129043: code review 8129043: api: remove Zone of net.IPNet from next.txt (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by mikio
Modified:
11 years, 11 months ago
Reviewers:
CC:
golang-dev, dave_cheney.net, bradfitz
Visibility:
Public.

Description

api: remove Zone of net.IPNet from next.txt Update issue 4234. Update issue 4501.

Patch Set 1 #

Patch Set 2 : diff -r 47934a0f435e https://code.google.com/p/go #

Patch Set 3 : diff -r 47934a0f435e https://code.google.com/p/go #

Patch Set 4 : diff -r 1e22ad69817a https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M api/next.txt View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8
mikio
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
11 years, 11 months ago (2013-03-29 02:58:55 UTC) #1
dave_cheney.net
I don't think issue 4232 is the correct one to reference. Please fix the description, ...
11 years, 11 months ago (2013-03-29 04:13:06 UTC) #2
mikio
PTAL > I'm guessing the next CL will remove net.IPNet from the code ? it's ...
11 years, 11 months ago (2013-03-29 04:27:05 UTC) #3
dave_cheney.net
LGTM. Thanks.
11 years, 11 months ago (2013-03-29 04:30:11 UTC) #4
mikio
Just noticed that Brad already said LGTM but its destination address did not contain golang-dev. ...
11 years, 11 months ago (2013-03-29 04:31:22 UTC) #5
bradfitz
Phones. How do they work? On Thu, Mar 28, 2013 at 9:31 PM, <mikioh.mikioh@gmail.com> wrote: ...
11 years, 11 months ago (2013-03-29 04:32:49 UTC) #6
bradfitz
LGTM
11 years, 11 months ago (2013-03-29 04:33:18 UTC) #7
mikio
11 years, 11 months ago (2013-03-29 06:07:44 UTC) #8
*** Submitted as https://code.google.com/p/go/source/detail?r=a4fff24827d4 ***

api: remove Zone of net.IPNet from next.txt

Update issue 4234.
Update issue 4501.

R=golang-dev, dave, bradfitz
CC=golang-dev
https://codereview.appspot.com/8129043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b