Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(473)

Issue 81250043: Fixed charm store series resolving issues.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 1 month ago by cmars
Modified:
10 years, 1 month ago
Reviewers:
mp+212991, fwereade
Visibility:
Public.

Description

Fixed charm store series resolving issues. Fixed an issue where trying to resolve series for a charm not found causes an HTTP 502, needed a nil check. Fixed an issue where the charm URL regex match for resolving series was too greedy, causing it to fail to resolve mysql, for example. Added test cases for the above. https://code.launchpad.net/~cmars/juju-core/cs-resolve-notfound-fix/+merge/212991 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -4 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M store/server.go View 1 chunk +1 line, -1 line 0 comments Download
M store/server_test.go View 1 chunk +17 lines, -0 lines 0 comments Download
M store/store.go View 2 chunks +5 lines, -3 lines 0 comments Download
M store/store_test.go View 3 chunks +55 lines, -0 lines 0 comments Download

Messages

Total messages: 2
cmars
Please take a look.
10 years, 1 month ago (2014-03-27 05:10:32 UTC) #1
fwereade
10 years, 1 month ago (2014-03-27 14:49:42 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b