Issue 8122043: code review 8122043: cmd/godoc: provide a link from notes to source location

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8122043: code review 8122043: cmd/godoc: provide a link from notes to source location (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by gri

Modified:
11 years, 11 months ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

cmd/godoc: provide a link from notes to source location

Patch Set 1 #

Patch Set 2 : diff -r f7d313b77a53 https://code.google.com/p/go #

Patch Set 3 : diff -r f7d313b77a53 https://code.google.com/p/go #

Patch Set 4 : diff -r 623b1b390dd6 https://code.google.com/p/go #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -14 lines)			Patch
M	lib/godoc/package.html	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/cmd/godoc/godoc.go	View	1	1 chunk	+23 lines, -9 lines	0 comments	Download
M	src/pkg/go/doc/doc.go	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/pkg/go/doc/reader.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

11 years, 11 months ago (2013-03-28 21:35:21 UTC) #1

LGTM except - do we really want to expose TODOs inside functions? i don't see ...

11 years, 11 months ago (2013-03-28 21:38:59 UTC) #2

gri

11 years, 11 months ago (2013-03-28 21:41:02 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=f9cb5530d0d8 ***

cmd/godoc: provide a link from notes to source location

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/8122043

Expand All Messages | Collapse All Messages