Issue 8118047: code review 8118047: testing: document that Log and Logf do not usually prod...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8118047: code review 8118047: testing: document that Log and Logf do not usually prod... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by r

Modified:
12 years, 1 month ago

Reviewers:

CC:
golang-dev, dsymonds

Visibility:
Public.

Description

testing: document that Log and Logf do not usually produce output The text is printed only if the test fails or -test.v is set. Document this behavior in the testing package and 'go help test'. Also put a 'go install' into mkdoc.sh so I don't get tricked by the process of updating the documentation ever again. Fixes issue 5174.

Patch Set 1 #

Patch Set 2 : diff -r fb78cf8fd5b5 https://code.google.com/p/go #

Patch Set 3 : diff -r fb78cf8fd5b5 https://code.google.com/p/go #

Patch Set 4 : diff -r c7f65b7a16ca https://code.google.com/p/go #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -4 lines)			Patch
M	src/cmd/go/doc.go	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/cmd/go/mkdoc.sh	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/go/test.go	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/pkg/testing/testing.go	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

12 years, 1 month ago (2013-04-01 20:45:26 UTC) #1

Hold off. Once again the go tool's documentation setup is vexing me.

12 years, 1 month ago (2013-04-01 20:48:26 UTC) #2

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.

12 years, 1 month ago (2013-04-01 20:50:47 UTC) #3

12 years, 1 month ago (2013-04-01 22:17:04 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=b5c8e7796d94 ***

testing: document that Log and Logf do not usually produce output
The text is printed only if the test fails or -test.v is set.
Document this behavior in the testing package and 'go help test'.
Also put a 'go install' into mkdoc.sh so I don't get tricked by the
process of updating the documentation ever again.

Fixes issue 5174.

R=golang-dev, dsymonds
CC=golang-dev
https://codereview.appspot.com/8118047

Expand All Messages | Collapse All Messages