Issue 8114043: code review 8114043: net/http: inline chunkWriter in response

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8114043: code review 8114043: net/http: inline chunkWriter in response (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by bradfitz

Modified:
11 years, 11 months ago

Reviewers:

CC:
golang-dev, gri

Visibility:
Public.

Description

net/http: inline chunkWriter in response A chunkWriter and a response are 1:1. Make them contiguous in memory and save an allocation. benchmark old ns/op new ns/op delta BenchmarkServerFakeConnWithKeepAliveLite 10715 10539 -1.64% benchmark old allocs new allocs delta BenchmarkServerFakeConnWithKeepAliveLite 21 20 -4.76% benchmark old bytes new bytes delta BenchmarkServerFakeConnWithKeepAliveLite 1626 1609 -1.05%

Patch Set 1 #

Patch Set 2 : diff -r a259257225e8 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r a259257225e8 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r a259257225e8 https://go.googlecode.com/hg/ #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	src/pkg/net/http/server.go	View	1	2 chunks	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 11 months ago (2013-03-28 20:12:12 UTC) #1

bradfitz

11 years, 11 months ago (2013-03-28 20:13:35 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=3587a167774e ***

net/http: inline chunkWriter in response

A chunkWriter and a response are 1:1. Make them contiguous in
memory and save an allocation.

benchmark                                   old ns/op    new ns/op    delta
BenchmarkServerFakeConnWithKeepAliveLite        10715        10539   -1.64%

benchmark                                  old allocs   new allocs    delta
BenchmarkServerFakeConnWithKeepAliveLite           21           20   -4.76%

benchmark                                   old bytes    new bytes    delta
BenchmarkServerFakeConnWithKeepAliveLite         1626         1609   -1.05%

R=golang-dev, gri
CC=golang-dev
https://codereview.appspot.com/8114043

Expand All Messages | Collapse All Messages