Issue 8108044: code review 8108044: cmd/godoc: cleanups

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8108044: code review 8108044: cmd/godoc: cleanups (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by gri

Modified:
11 years, 11 months ago

Reviewers:

CC:
golang-dev, bradfitz

Visibility:
Public.

Description

cmd/godoc: cleanups - removed gratuitous empty lines that creeped into command line output - changed comment color to a dark green so that links don't visually melt into them - removed some TODOs - updated doc.go

Patch Set 1 #

Patch Set 2 : diff -r 833bf2ef1527 https://code.google.com/p/go #

Patch Set 3 : diff -r 833bf2ef1527 https://code.google.com/p/go #

Patch Set 4 : diff -r 833bf2ef1527 https://code.google.com/p/go #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -13 lines)			Patch
M	doc/style.css	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/godoc/package.txt	View	1	4 chunks	+7 lines, -8 lines	0 comments	Download
M	src/cmd/godoc/doc.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/cmd/godoc/index.go	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/cmd/godoc/utils.go	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

11 years, 11 months ago (2013-03-28 19:50:54 UTC) #1

gri

11 years, 11 months ago (2013-03-28 20:05:37 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=d2c7e1883818 ***

cmd/godoc: cleanups

- removed gratuitous empty lines that creeped into command line output
- changed comment color to a dark green so that links don't visually melt into
them
- removed some TODOs
- updated doc.go

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/8108044

Expand All Messages | Collapse All Messages