Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(12649)

Issue 8105043: Updated the charm to use the new node versions

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by jeff.pihach
Modified:
11 years, 1 month ago
Reviewers:
mp+156032, gary.poster, bcsaller
Visibility:
Public.

Description

Updated the charm to use the new node versions The issue causing the original revert to node 0.8 has been resolved so we are now allowing the charm to use the latest version of node. https://code.launchpad.net/~hatch/charms/precise/juju-gui/node10-upgrade/+merge/156032 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Updated the charm to use the new node versions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M hooks/utils.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5
jeff.pihach
Please take a look.
11 years, 1 month ago (2013-03-28 17:30:58 UTC) #1
gary.poster
LGTM. Thank you! Gary
11 years, 1 month ago (2013-03-28 18:11:25 UTC) #2
bcsaller
LGTM
11 years, 1 month ago (2013-03-28 18:22:56 UTC) #3
jeff.pihach
Thanks for the reviews!
11 years, 1 month ago (2013-03-28 18:26:27 UTC) #4
jeff.pihach
11 years, 1 month ago (2013-03-28 18:26:42 UTC) #5
*** Submitted:

Updated the charm to use the new node versions

The issue causing the original revert to node 0.8
has been resolved so we are now allowing the charm to
use the latest version of node.

R=gary.poster, bcsaller
CC=
https://codereview.appspot.com/8105043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b