DescriptionCreate a view for the browser charm details.
- Drive by fixes for some missing deps
- Drive by for the api url in the prod config
- Refactory out the logic of the charm details from Fullscreen to it's own
view so it can be reused hopefully in the Sidebar View as well.
- Add the icon to the BrowserCharm model since it's new.
- Add the `file` Charmworld API endpoint used for loading the readme contents
if available.
- Fix broken HTML heh
- Add events with place holder functions for clicking 'add' and 'open
changelog'.
- Add basic tests for the BrowserCharmView
- If you want to QA, go to /bws/sidebar and select one of the charm links
displayed. It will load details for that charm. Note: there's an upstream
Charmworld API issue if the charm *does* have a README file. It'll throw an
error currently and a fix to Charmworld is submitted but not in staging yet.
https://code.launchpad.net/~rharding/juju-gui/clean_charmview/+merge/156054
(do not edit description out of merge proposal)
Patch Set 1 #
Total comments: 8
Patch Set 2 : Create a view for the browser charm details. #
Total comments: 6
Patch Set 3 : Create a view for the browser charm details. #Patch Set 4 : Create a view for the browser charm details. #Patch Set 5 : Create a view for the browser charm details. #Patch Set 6 : Create a view for the browser charm details. #
MessagesTotal messages: 8
|