code review 8101043: net/http: more tests, better comments, remove an allocation

net/http: more tests, better comments, remove an allocation

Add more tests around the various orders handlers can access
and flush response headers.

Also clarify the documentation on fields of response and
chunkWriter.

While there, remove an allocation (a header clone) for simple
handlers.

benchmark                                   old ns/op    new ns/op    delta
BenchmarkServerFakeConnWithKeepAliveLite        15245        14966   -1.83%

benchmark                                  old allocs   new allocs    delta
BenchmarkServerFakeConnWithKeepAliveLite           24           23   -4.17%

benchmark                                   old bytes    new bytes    delta
BenchmarkServerFakeConnWithKeepAliveLite         1717         1668   -2.85%

[bradfitz, 2013-03-28 17:26:57]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[gri, 2013-03-28 18:21:42]

LGTM

https://codereview.appspot.com/8101043/diff/5001/src/pkg/net/http/server.go
File src/pkg/net/http/server.go (right):

https://codereview.appspot.com/8101043/diff/5001/src/pkg/net/http/server.go#n...
src/pkg/net/http/server.go:231: // wroteHeader is whether the header's been
sent.  unlike
s/is/reports/ ?
s/is/tells/ ?

https://codereview.appspot.com/8101043/diff/5001/src/pkg/net/http/server.go#n...
src/pkg/net/http/server.go:232: // (*response).wroteHeader, this one is whether
the header
is -> tells ?

[bradfitz, 2013-03-28 18:35:29]

*** Submitted as https://code.google.com/p/go/source/detail?r=833bf2ef1527 ***

net/http: more tests, better comments, remove an allocation

Add more tests around the various orders handlers can access
and flush response headers.

Also clarify the documentation on fields of response and
chunkWriter.

While there, remove an allocation (a header clone) for simple
handlers.

benchmark                                   old ns/op    new ns/op    delta
BenchmarkServerFakeConnWithKeepAliveLite        15245        14966   -1.83%

benchmark                                  old allocs   new allocs    delta
BenchmarkServerFakeConnWithKeepAliveLite           24           23   -4.17%

benchmark                                   old bytes    new bytes    delta
BenchmarkServerFakeConnWithKeepAliveLite         1717         1668   -2.85%

R=golang-dev, gri
CC=golang-dev
https://codereview.appspot.com/8101043

https://codereview.appspot.com/8101043/diff/5001/src/pkg/net/http/server.go
File src/pkg/net/http/server.go (right):

https://codereview.appspot.com/8101043/diff/5001/src/pkg/net/http/server.go#n...
src/pkg/net/http/server.go:231: // wroteHeader is whether the header's been
sent.  unlike
On 2013/03/28 18:21:42, gri wrote:
> s/is/reports/ ?
> s/is/tells/ ?

done, and reordered a bit for clarity.

https://codereview.appspot.com/8101043/diff/5001/src/pkg/net/http/server.go#n...
src/pkg/net/http/server.go:232: // (*response).wroteHeader, this one is whether
the header
On 2013/03/28 18:21:42, gri wrote:
> is -> tells ?

Done.