Expose more delta information

Expose more delta information

This exposes more unit attributes to the watchers.  The only true additions in this branch are to the params.go file, and the associated test.  After this change, much more (but unfortunately still not all) of the values we need will be exposed in the watcher.

The branch is very large because of mechanical changes that prevent circular imports.  UnitStatus, Port, and ResolvedMode needed to move into the params package, and this required a very large number of mechanical import changes.  The rest of the changes in this branch, other than some test fix-ups in megawatcher_internal_test.go, are just these mechanical changes to handle the new location.

https://code.launchpad.net/~gary/juju-core/more-info/+merge/156406

(do not edit description out of merge proposal)

[gary.poster, 2013-04-01 20:06:08]

Please take a look.

[thumper, 2013-04-01 20:46:58]

LGTM modulo the comment below

https://codereview.appspot.com/8086045/diff/1/state/api/params/params_test.go
File state/api/params/params_test.go (right):

https://codereview.appspot.com/8086045/diff/1/state/api/params/params_test.go...
state/api/params/params_test.go:55: Series:   "series", // E.g. precise.
Can we change the test so instead of using comments for "precise" and
"wordpress" we instead have the test output show this?

[fwereade, 2013-04-01 22:52:58]

LGTM -- maybe ping me tomorrow about status and status info?

https://codereview.appspot.com/8086045/diff/1/state/api/params/params.go
File state/api/params/params.go (right):

https://codereview.appspot.com/8086045/diff/1/state/api/params/params.go#newc...
state/api/params/params.go:340: StatusInfo     string
Hmm, there may be some changes to status landing shortly. How bad would it be
for you if statuses were to move off the unit document and into their own
collection? I guess it'd be more megawatcher work, but I guess there may be
further consequences on your side?

https://codereview.appspot.com/8086045/diff/1/state/api/params/params_test.go
File state/api/params/params_test.go (right):

https://codereview.appspot.com/8086045/diff/1/state/api/params/params_test.go...
state/api/params/params_test.go:55: Series:   "series", // E.g. precise.
On 2013/04/01 20:46:58, thumper wrote:
> Can we change the test so instead of using comments for "precise" and
> "wordpress" we instead have the test output show this?

+1

[gary.poster, 2013-04-01 23:53:10]

*** Submitted:

Expose more delta information

This exposes more unit attributes to the watchers.  The only true additions in
this branch are to the params.go file, and the associated test.  After this
change, much more (but unfortunately still not all) of the values we need will
be exposed in the watcher.

The branch is very large because of mechanical changes that prevent circular
imports.  UnitStatus, Port, and ResolvedMode needed to move into the params
package, and this required a very large number of mechanical import changes. 
The rest of the changes in this branch, other than some test fix-ups in
megawatcher_internal_test.go, are just these mechanical changes to handle the
new location.

R=thumper, fwereade
CC=
https://codereview.appspot.com/8086045

https://codereview.appspot.com/8086045/diff/1/state/api/params/params_test.go
File state/api/params/params_test.go (right):

https://codereview.appspot.com/8086045/diff/1/state/api/params/params_test.go...
state/api/params/params_test.go:55: Series:   "series", // E.g. precise.
On 2013/04/01 20:46:58, thumper wrote:
> Can we change the test so instead of using comments for "precise" and
> "wordpress" we instead have the test output show this?

Done.

[gary.poster, 2013-04-01 23:59:17]

Thank you both very much for the prompt review.

On 2013/04/01 22:52:58, fwereade wrote:
> LGTM -- maybe ping me tomorrow about status and status info?

OK, will do.

Short answer is that, if we were not under time pressure, I would have zero
concerns.  With the time pressure, and the fact that I realized last Friday that
we are also already going to need to add separate watchers for config and
constraint docs, I'm a lot more nervous about the change.  If we could postpone
the change to post 13.04 that would be fabulous.  If we can't, we'll just need
to strategize, and see how quickly Roger and we can whip up the necessary code
on the GUI/API side.