Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2352)

Issue 8083044: Tweak CI tests

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by gary.poster
Modified:
11 years, 1 month ago
Reviewers:
rharding, matthew.scott, mp+156210
Visibility:
Public.

Description

Tweak CI tests Retry unit tests more, and only specify an instance type in canonistack. https://code.launchpad.net/~gary/juju-gui/ci2/+merge/156210 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Tweak CI tests #

Patch Set 3 : Tweak CI tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -15 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M lib/deploy_charm_for_testing.py View 3 chunks +13 lines, -6 lines 0 comments Download
M test/test_charm_running.py View 1 chunk +14 lines, -9 lines 0 comments Download

Messages

Total messages: 5
gary.poster
Please take a look.
11 years, 1 month ago (2013-03-29 18:57:25 UTC) #1
matthew.scott
LGTM - thanks for the branch. Unfortunate issue to have to work around :/
11 years, 1 month ago (2013-03-29 20:02:35 UTC) #2
rharding
LGTM https://codereview.appspot.com/8083044/diff/1/test/test_charm_running.py File test/test_charm_running.py (right): https://codereview.appspot.com/8083044/diff/1/test/test_charm_running.py#newcode52 test/test_charm_running.py:52: timeout=90) I can't tell for sure from the ...
11 years, 1 month ago (2013-03-29 20:11:51 UTC) #3
gary.poster
*** Submitted: Tweak CI tests Retry unit tests more, and only specify an instance type ...
11 years, 1 month ago (2013-04-01 13:06:25 UTC) #4
gary.poster
11 years, 1 month ago (2013-04-01 13:06:56 UTC) #5
Thank you both!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b