Added support for juju-core.

Added support for juju-core.

It is now possible to deploy the charm
in a juju-core environment.
The GUI correctly  connects to the juju-core 
API server.

https://code.launchpad.net/~frankban/charms/precise/juju-gui/bug-1126213-support-juju-core/+merge/155960

(do not edit description out of merge proposal)

[frankban, 2013-03-28 13:16:59]

Please take a look.

[gary.poster, 2013-03-28 13:39:50]

Trivial comments.  Thank you!  I want to qa before approving, but very happy if
someone else beats me to it.

https://codereview.appspot.com/8081043/diff/1/hooks/config-changed
File hooks/config-changed (right):

https://codereview.appspot.com/8081043/diff/1/hooks/config-changed#newcode72
hooks/config-changed:72: # skipped the charm is deployed in a juju-core
environment where the
trivial: "# skipped if the charm..." (needs an "if")

https://codereview.appspot.com/8081043/diff/1/hooks/utils.py
File hooks/utils.py (right):

https://codereview.appspot.com/8081043/diff/1/hooks/utils.py#newcode112
hooks/utils.py:112: # include the API address. For now retrieve it from the
machine agent file.
Suggest filing a juju-core bug affecting juju-gui about this so we can know when
to change this code?

https://codereview.appspot.com/8081043/diff/1/hooks/utils.py#newcode367
hooks/utils.py:367: # WebSocket connections.
It took me a minute to remember that this was not necessary for JujuCore because
the system had the proper certificate installed already, so we didn't have to do
anything ourselves.  Maybe it would be worth mentioning this in the comment?

[frankban, 2013-03-28 15:19:55]

Please take a look.

https://codereview.appspot.com/8081043/diff/1/hooks/config-changed
File hooks/config-changed (right):

https://codereview.appspot.com/8081043/diff/1/hooks/config-changed#newcode72
hooks/config-changed:72: # skipped the charm is deployed in a juju-core
environment where the
On 2013/03/28 13:39:50, gary.poster wrote:
> trivial: "# skipped if the charm..." (needs an "if")

Done.

https://codereview.appspot.com/8081043/diff/1/hooks/utils.py
File hooks/utils.py (right):

https://codereview.appspot.com/8081043/diff/1/hooks/utils.py#newcode112
hooks/utils.py:112: # include the API address. For now retrieve it from the
machine agent file.
On 2013/03/28 13:39:50, gary.poster wrote:
> Suggest filing a juju-core bug affecting juju-gui about this so we can know
when
> to change this code?

Filed bug 1161443, referenced in the XXX comment.

https://codereview.appspot.com/8081043/diff/1/hooks/utils.py#newcode367
hooks/utils.py:367: # WebSocket connections.
On 2013/03/28 13:39:50, gary.poster wrote:
> It took me a minute to remember that this was not necessary for JujuCore
because
> the system had the proper certificate installed already, so we didn't have to
do
> anything ourselves.  Maybe it would be worth mentioning this in the comment?

Done.

[gary.poster, 2013-03-28 15:31:56]

LGTM.  QA was great.  Thank you!

[bac, 2013-03-28 15:37:34]

It LGTM but like Gary I'd like to QA it.  I'll do so after lunch if he doesn't
beat me to it.

https://codereview.appspot.com/8081043/diff/1/hooks/utils.py
File hooks/utils.py (right):

https://codereview.appspot.com/8081043/diff/1/hooks/utils.py#newcode66
hooks/utils.py:66: 
I don't see this used anywhere.  Nor tempfile.  Can you run the linter?

[frankban, 2013-03-28 15:58:18]

On 2013/03/28 15:37:34, bac wrote:
> It LGTM but like Gary I'd like to QA it.  I'll do so after lunch if he doesn't
> beat me to it.

He did! Thanks for your reviews Gary and Brad.

> 
> https://codereview.appspot.com/8081043/diff/1/hooks/utils.py
> File hooks/utils.py (right):
> 
> https://codereview.appspot.com/8081043/diff/1/hooks/utils.py#newcode66
> hooks/utils.py:66: 
> I don't see this used anywhere.  Nor tempfile.  Can you run the linter?

tempita is used in render_to_file, tempfile in fetch_gui.

[frankban, 2013-03-28 16:25:16]

*** Submitted:

Added support for juju-core.

It is now possible to deploy the charm
in a juju-core environment.
The GUI correctly  connects to the juju-core 
API server.

R=gary.poster, bac
CC=
https://codereview.appspot.com/8081043

[bac, 2013-03-28 17:45:36]

> > I don't see this used anywhere.  Nor tempfile.  Can you run the linter?
> 
> tempita is used in render_to_file, tempfile in fetch_gui.

Thanks, I realize now I failed to 'expand all' so I wasn't seeing the whole
file. Sorry for the noise.