Issue 8078043: state/watcher: allow short period

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8078043: state/watcher: allow short period

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by rog

Modified:
11 years, 1 month ago

Reviewers:
dimitern, mp+155945, fwereade

Visibility:
Public.

Description

state/watcher: allow short period We make the tests pass when the period is short, and expose the Period variable so that external tests have the possibility of altering it. https://code.launchpad.net/~rogpeppe/juju-core/262-watcher-quick-poll/+merge/155945 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state/watcher: allow short period #

Patch Set 3 : state/watcher: allow short period #

Total comments: 4

Patch Set 4 : state/watcher: allow short period #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+188 lines, -144 lines)			Patch
A	[revision details]	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
D	state/watcher/export_test.go	View		1 chunk	+0 lines, -15 lines	0 comments	Download
M	state/watcher/helpers_test.go	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	state/watcher/watcher.go	View	1 2 3	2 chunks	+4 lines, -3 lines	0 comments	Download
M	state/watcher/watcher_test.go	View	1 2 3	28 chunks	+180 lines, -124 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

fwereade

Very nice, just a quibble and a typo, otherwise LGTM. https://codereview.appspot.com/8078043/diff/4001/state/watcher/watcher_test.go File state/watcher/watcher_test.go (right): https://codereview.appspot.com/8078043/diff/4001/state/watcher/watcher_test.go#newcode66 ...

11 years, 1 month ago (2013-03-30 05:21:54 UTC) #4

rog

11 years, 1 month ago (2013-04-03 12:36:17 UTC) #5

*** Submitted:

state/watcher: allow short period

We make the tests pass when the period is
short, and expose the Period variable
so that external tests have the possibility
of altering it.

R=dimitern, fwereade
CC=
https://codereview.appspot.com/8078043

https://codereview.appspot.com/8078043/diff/4001/state/watcher/watcher_test.go
File state/watcher/watcher_test.go (right):

https://codereview.appspot.com/8078043/diff/4001/state/watcher/watcher_test.g...
state/watcher/watcher_test.go:66: var _ = Suite(&FastPeriodSuite{})
On 2013/03/30 05:21:54, fwereade wrote:
> Please move the test suite declarations down next to their implementations,
for
> the sake of my puny brain ;),

Done.

https://codereview.appspot.com/8078043/diff/4001/state/watcher/watcher_test.g...
state/watcher/watcher_test.go:68: // SlowPeriodFastPeriodSuite implements tests
On 2013/03/30 05:21:54, fwereade wrote:
> s/FastPeriod//

Done.

Expand All Messages | Collapse All Messages