Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(494)

Issue 8071044: Update charm small to match "Charm Token".

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 8 months ago by j.c.sackett
Modified:
8 years, 8 months ago
Reviewers:
rharding, mp+156415, matthew.scott
Visibility:
Public.

Description

Update charm small to match "Charm Token". - CharmSmall is renamed CharmToken, with all relevant references (e.g. css, events, prefixes) updated accordingly. - CharmToken loses its rating. - CharmToken gets recent_downloads, recent_commits - Template is updated - Charm model is updated to include relevant data (e.g. recent_commits) https://code.launchpad.net/~jcsackett/juju-gui/charm-small-is-charm-token/+merge/156415 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 5

Patch Set 2 : Update charm small to match "Charm Token". #

Patch Set 3 : Update charm small to match "Charm Token". #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -74 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M app/models/charm.js View 1 2 4 chunks +19 lines, -2 lines 0 comments Download
M app/modules-debug.js View 1 chunk +4 lines, -4 lines 0 comments Download
M app/subapps/browser/views/sidebar.js View 3 chunks +4 lines, -4 lines 0 comments Download
M app/subapps/browser/views/view.js View 1 chunk +1 line, -1 line 0 comments Download
M app/templates/charm-token.handlebars View 1 1 chunk +11 lines, -2 lines 0 comments Download
M app/widgets/charm-container.js View 5 chunks +6 lines, -6 lines 0 comments Download
M app/widgets/charm-token.js View 1 4 chunks +56 lines, -25 lines 0 comments Download
M lib/views/browser/charm-container.less View 1 chunk +1 line, -1 line 0 comments Download
M lib/views/browser/charm-token.less View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/views/stylesheet.less View 1 chunk +1 line, -1 line 0 comments Download
M test/index.html View 1 chunk +1 line, -1 line 0 comments Download
M test/test_charm_container.js View 4 chunks +8 lines, -8 lines 0 comments Download
M test/test_charm_slider.js View 1 chunk +1 line, -1 line 0 comments Download
M test/test_charm_token.js View 1 2 chunks +12 lines, -16 lines 0 comments Download

Messages

Total messages: 7
j.c.sackett
Please take a look.
8 years, 8 months ago (2013-04-01 20:42:12 UTC) #1
matthew.scott
LGTM, thanks! One note with the SVGs which is a not-this-branch sort of thing. In ...
8 years, 8 months ago (2013-04-01 20:57:50 UTC) #2
j.c.sackett
On 2013/04/01 20:57:50, matthew.scott wrote: > LGTM, thanks! > > One note with the SVGs ...
8 years, 8 months ago (2013-04-01 20:59:59 UTC) #3
rharding
LGTM overall with a couple of trivial requests. https://codereview.appspot.com/8071044/diff/1/app/models/charm.js File app/models/charm.js (right): https://codereview.appspot.com/8071044/diff/1/app/models/charm.js#newcode369 app/models/charm.js:369: recent_downloads: ...
8 years, 8 months ago (2013-04-01 23:53:17 UTC) #4
j.c.sackett
Please take a look.
8 years, 8 months ago (2013-04-02 16:11:35 UTC) #5
rharding
LGTM
8 years, 8 months ago (2013-04-02 16:25:06 UTC) #6
j.c.sackett
8 years, 8 months ago (2013-04-02 20:17:21 UTC) #7
*** Submitted:

Update charm small to match "Charm Token".

- CharmSmall is renamed CharmToken, with all relevant references (e.g. css,
events, prefixes) updated accordingly.
- CharmToken loses its rating.
- CharmToken gets recent_downloads, recent_commits
- Template is updated
- Charm model is updated to include relevant data (e.g. recent_commits)

R=matthew.scott, rharding
CC=
https://codereview.appspot.com/8071044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b