Update charm small to match "Charm Token".

Update charm small to match "Charm Token".

- CharmSmall is renamed CharmToken, with all relevant references (e.g. css,
events, prefixes) updated accordingly.
- CharmToken loses its rating.
- CharmToken gets recent_downloads, recent_commits
- Template is updated
- Charm model is updated to include relevant data (e.g. recent_commits)

https://code.launchpad.net/~jcsackett/juju-gui/charm-small-is-charm-token/+merge/156415

(do not edit description out of merge proposal)

[j.c.sackett, 2013-04-01 20:42:12]

Please take a look.

[matthew.scott, 2013-04-01 20:57:50]

LGTM, thanks!

One note with the SVGs which is a not-this-branch sort of thing.  In the past,
we've stored SVGs in the ApplicationCache to prevent downloading them on each
use.  These are smaller, but I know we have these and several other non-sprited
image assets which may do well to wind up in the appcache once design on those
elements slows down.  OTOH, SVGs can be compressed to help out.  Just some
thoughts; I'll make a discussion card to bring up sometime in the future.

[j.c.sackett, 2013-04-01 20:59:59]

On 2013/04/01 20:57:50, matthew.scott wrote:
> LGTM, thanks!
> 
> One note with the SVGs which is a not-this-branch sort of thing.  In the past,
> we've stored SVGs in the ApplicationCache to prevent downloading them on each
> use.  These are smaller, but I know we have these and several other
non-sprited
> image assets which may do well to wind up in the appcache once design on those
> elements slows down.  OTOH, SVGs can be compressed to help out.  Just some
> thoughts; I'll make a discussion card to bring up sometime in the future.

Cool; if you get an idea of which meeting that will end up being discussed in,
can you let me know? If it's 6 one way half a dozen the other to keep it updated
as design elements change, I'm happy to do a follow up at any point.

[rharding, 2013-04-01 23:53:17]

LGTM overall with a couple of trivial requests.

https://codereview.appspot.com/8071044/diff/1/app/models/charm.js
File app/models/charm.js (right):

https://codereview.appspot.com/8071044/diff/1/app/models/charm.js#newcode369
app/models/charm.js:369: recent_downloads: {},
didn't we also mention that recent_downloads is actually
'downloads_in_last_30_days' from the api and that we need to add a little code
in the initializer() of our model? this.set('recent_downloads',
cfg.downloads_in_last_30_days)?

https://codereview.appspot.com/8071044/diff/1/app/templates/charm-token.handl...
File app/templates/charm-token.handlebars (right):

https://codereview.appspot.com/8071044/diff/1/app/templates/charm-token.handl...
app/templates/charm-token.handlebars:7: {{#tested_providers}}
can you indent the levels here to break out blocks from just normal stuff. I had
missed the # and thought this was going to just output the tested_providers
until I went through more.

https://codereview.appspot.com/8071044/diff/1/app/templates/charm-token.handl...
app/templates/charm-token.handlebars:17: </div>
For right now can you place holder the up/down arrows with spans containing the
^ or V. It'll look ugly be give things a little indent for alignment and make
sure we get back to that.

https://codereview.appspot.com/8071044/diff/1/app/widgets/charm-token.js
File app/widgets/charm-token.js (right):

https://codereview.appspot.com/8071044/diff/1/app/widgets/charm-token.js#newc...
app/widgets/charm-token.js:40: _getTemplateAttrs: function() {
for ease of testing and such I'd be better I think if this was more 'static' and
didn't require access to the instance. I'd pass in the this.getAttrs() from the
model here.

https://codereview.appspot.com/8071044/diff/1/test/test_charm_token.js
File test/test_charm_token.js (right):

https://codereview.appspot.com/8071044/diff/1/test/test_charm_token.js#newcode26
test/test_charm_token.js:26: });
I think it'd be good to have a test against the method that mutates the object
into the template data. That way those 'exceptions' are explicit and checked
against which is easier to debug vs going through the dom checks in the rendered
output.

[j.c.sackett, 2013-04-02 16:11:35]

Please take a look.

[rharding, 2013-04-02 16:25:06]

LGTM

[j.c.sackett, 2013-04-02 20:17:21]

*** Submitted:

Update charm small to match "Charm Token".

- CharmSmall is renamed CharmToken, with all relevant references (e.g. css,
events, prefixes) updated accordingly.
- CharmToken loses its rating.
- CharmToken gets recent_downloads, recent_commits
- Template is updated
- Charm model is updated to include relevant data (e.g. recent_commits)

R=matthew.scott, rharding
CC=
https://codereview.appspot.com/8071044