code review 8069044: cmd/godoc: don't crash if there's no documentation

cmd/godoc: don't crash if there's no documentation

Fixes regression introduced by CL 7860049.

[gri, 2013-03-28 05:58:20]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[kisielk, 2013-03-28 06:37:47]

LGTM

Fixed the crashes I was seeing when running "godoc ."

[dave_cheney.net, 2013-03-28 10:08:34]

LGTM. Thank you.

https://codereview.appspot.com/8069044/diff/2002/src/cmd/godoc/main.go
File src/cmd/godoc/main.go (right):

https://codereview.appspot.com/8069044/diff/2002/src/cmd/godoc/main.go#newcod...
src/cmd/godoc/main.go:407: log.Fatalf("%s: no such directory or package",
flag.Arg(0))
I can't seem to trigger this condition, possibly something above it is already
making it impossible.

[gri, 2013-03-28 15:46:22]

*** Submitted as https://code.google.com/p/go/source/detail?r=2680b2be958b ***

cmd/godoc: don't crash if there's no documentation

Fixes regression introduced by CL 7860049.

R=golang-dev, kamil.kisiel, dave
CC=golang-dev
https://codereview.appspot.com/8069044

https://codereview.appspot.com/8069044/diff/2002/src/cmd/godoc/main.go
File src/cmd/godoc/main.go (right):

https://codereview.appspot.com/8069044/diff/2002/src/cmd/godoc/main.go#newcod...
src/cmd/godoc/main.go:407: log.Fatalf("%s: no such directory or package",
flag.Arg(0))
On 2013/03/28 10:08:34, dfc wrote:
> I can't seem to trigger this condition, possibly something above it is already
> making it impossible.

try: godoc cmd/foo

(assuming there's no cmd foo)

Before (ie. before changing from PageInfo to *PageInfo) this would just go
through silently. It seems more in sync with the rest to report an error.

[gri, 2013-03-28 15:47:52]

try: godoc cmd/foo

(assuming there's no command called foo)


On Thu, Mar 28, 2013 at 3:08 AM, <dave@cheney.net> wrote:

> LGTM. Thank you.
>
>
>
https://codereview.appspot.**com/8069044/diff/2002/src/cmd/**godoc/main.go<ht...
> File src/cmd/godoc/main.go (right):
>
> https://codereview.appspot.**com/8069044/diff/2002/src/cmd/**
>
godoc/main.go#newcode407<https://codereview.appspot.com/8069044/diff/2002/src/cmd/godoc/main.go#newcode407>
> src/cmd/godoc/main.go:407: log.Fatalf("%s: no such directory or
> package", flag.Arg(0))
> I can't seem to trigger this condition, possibly something above it is
> already making it impossible.
>
>
https://codereview.appspot.**com/8069044/<https://codereview.appspot.com/8069...
>

[dave_cheney.net, 2013-03-29 03:44:36]

Thank you, I understand now.

On Fri, Mar 29, 2013 at 2:47 AM, Robert Griesemer <gri@golang.org> wrote:
> try: godoc cmd/foo
>
> (assuming there's no command called foo)
>
>
> On Thu, Mar 28, 2013 at 3:08 AM, <dave@cheney.net> wrote:
>>
>> LGTM. Thank you.
>>
>>
>> https://codereview.appspot.com/8069044/diff/2002/src/cmd/godoc/main.go
>> File src/cmd/godoc/main.go (right):
>>
>>
>>
https://codereview.appspot.com/8069044/diff/2002/src/cmd/godoc/main.go#newcod...
>> src/cmd/godoc/main.go:407: log.Fatalf("%s: no such directory or
>> package", flag.Arg(0))
>> I can't seem to trigger this condition, possibly something above it is
>> already making it impossible.
>>
>> https://codereview.appspot.com/8069044/
>
>