Fix Openstack storage.Get retries

Fix Openstack storage.Get retries

storage.Get was retrying unecessarily if there was an error.
I also tweaked the logic for not found errors in the shortAttempts
loop to make it easier to read, and did the sanme for ec2.

https://code.launchpad.net/~wallyworld/juju-core/too-many-storage-retries/+merge/155883

(do not edit description out of merge proposal)

[wallyworld, 2013-03-28 02:24:31]

Please take a look.

[jameinel, 2013-03-28 03:47:02]

LGTM

https://codereview.appspot.com/8064043/diff/1/environs/openstack/storage.go
File environs/openstack/storage.go (right):

https://codereview.appspot.com/8064043/diff/1/environs/openstack/storage.go#n...
environs/openstack/storage.go:57: return
This would be easier to understand if we did:
if !error.IsNotFound(err) { return err }

Rather than having to think "if we don't continue then we, oh return".

Otherwise LGTMHy

[thumper, 2013-03-28 04:10:13]

LGTM with John's suggestion.

https://codereview.appspot.com/8064043/diff/1/environs/openstack/storage.go
File environs/openstack/storage.go (right):

https://codereview.appspot.com/8064043/diff/1/environs/openstack/storage.go#n...
environs/openstack/storage.go:57: return
On 2013/03/28 03:47:02, jameinel wrote:
> This would be easier to understand if we did:
> if !error.IsNotFound(err) { return err }
> 
> Rather than having to think "if we don't continue then we, oh return".
> 
> Otherwise LGTM

I agree with John on this.

[wallyworld, 2013-03-28 05:18:26]

Please take a look.

[jameinel, 2013-03-28 05:33:59]

LGTM

[wallyworld, 2013-03-28 05:37:44]

*** Submitted:

Fix Openstack storage.Get retries

storage.Get was retrying unecessarily if there was an error.
I also tweaked the logic for not found errors in the shortAttempts
loop to make it easier to read, and did the sanme for ec2.

R=jameinel, thumper
CC=
https://codereview.appspot.com/8064043