Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2592)

Issue 8058043: Fix a bad event subscription and Next request args

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by benji
Modified:
11 years, 1 month ago
Reviewers:
rharding, mp+155844, jeff.pihach
Visibility:
Public.

Description

Fix a bad event subscription and Next request args Fixes bug 1161000. https://code.launchpad.net/~benji/juju-gui/1161000-fix-go-Next-arguments/+merge/155844 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fix a bad event subscription and Next request args #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/store/env/go.js View 2 chunks +3 lines, -4 lines 0 comments Download
M test/test_env_go.js View 1 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 4
benji
Please take a look.
11 years, 1 month ago (2013-03-27 19:59:45 UTC) #1
rharding
LGTM
11 years, 1 month ago (2013-03-27 20:04:43 UTC) #2
jeff.pihach
LGTM Thanks!
11 years, 1 month ago (2013-03-27 20:08:34 UTC) #3
benji
11 years, 1 month ago (2013-03-28 12:15:24 UTC) #4
*** Submitted:

Fix a bad event subscription and Next request args

Fixes bug 1161000.

R=rharding, jeff.pihach
CC=
https://codereview.appspot.com/8058043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b