code review 80560045: cmd/gc: fix spurious "bad negated constant" for complex...

cmd/gc: fix spurious "bad negated constant" for complex constants.
Fixes issue 7648.

[minux1, 2014-03-26 18:45:21]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[r, 2014-03-27 11:58:43]

LGTM

[remyoudompheng, 2014-03-27 17:12:20]

On 2014/03/27 11:58:43, r wrote:
> LGTM

Instead of changing the export data grammar to accept '+-' an alternative is to
fix Vconv in gc/fmt.c to avoid bad sequences when imaginary part is negative.

[minux1, 2014-03-27 18:40:03]

On Thu, Mar 27, 2014 at 1:12 PM, <remyoudompheng@gmail.com> wrote:

> Instead of changing the export data grammar to accept '+-' an
> alternative is to fix Vconv in gc/fmt.c to avoid bad sequences when
> imaginary part is negative.
>
I tried this, but our parser doesn't accept a-bi either.
issue7648_2.go:2: syntax error: unexpected -, expecting +

[jscrockett01, 2014-03-31 19:27:23]

On Thursday, March 27, 2014 2:39:43 PM UTC-4, minux wrote:
> On Thu, Mar 27, 2014 at 1:12 PM,  <remyoud...@gmail.com> wrote:
> 
> 
> Instead of changing the export data grammar to accept '+-' an
> 
> 
> 
> alternative is to fix Vconv in gc/fmt.c to avoid bad sequences when
> 
> imaginary part is negative.
> 
> I tried this, but our parser doesn't accept a-bi either.
> issue7648_2.go:2: syntax error: unexpected -, expecting + 

minux, thanks for the quick fix on this bug.  Is anything else blocking
submission?

[minux1, 2014-03-31 19:31:40]

On Mon, Mar 31, 2014 at 3:27 PM, <jscrockett01@gmail.com> wrote:

> On Thursday, March 27, 2014 2:39:43 PM UTC-4, minux wrote:
> > On Thu, Mar 27, 2014 at 1:12 PM,  <remyoud...@gmail.com> wrote:
> > Instead of changing the export data grammar to accept '+-' an
> > alternative is to fix Vconv in gc/fmt.c to avoid bad sequences when
> > imaginary part is negative.
> > I tried this, but our parser doesn't accept a-bi either.
> > issue7648_2.go:2: syntax error: unexpected -, expecting +
> minux, thanks for the quick fix on this bug.  Is anything else blocking
> submission?

I'm waiting for Remy's feedback.

[remyoudompheng, 2014-03-31 20:38:14]

LGTM

i don't find a really better way, the export syntax of complex literals has been
weird for a long time.

[minux1, 2014-04-01 06:55:43]

*** Submitted as https://code.google.com/p/go/source/detail?r=f8a06e7f703d ***

cmd/gc: fix spurious "bad negated constant" for complex constants.
Fixes issue 7648.

LGTM=r, remyoudompheng
R=golang-codereviews, r, remyoudompheng, jscrockett01
CC=golang-codereviews
https://codereview.appspot.com/80560045