Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2551)

Issue 8055043: Update more parts to use YUI responsive.

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by rharding
Modified:
11 years ago
Reviewers:
mp+155752, jeff.pihach, gary.poster
Visibility:
Public.

Description

Update more parts to use YUI responsive. - Submitted on behalf of Huw see: https://code.launchpad.net/~huwshimi/juju-gui/make-grid-responsive/+merge/155652 Applied the YUI reponsive grids to make some content and menus responsive. Fixed breakages that occured as a result. There is a lot left to be made responsive, but that will be changed as the new design is applied. https://code.launchpad.net/~rharding/juju-gui/more_yuigrids/+merge/155752 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update more parts to use YUI responsive. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -25 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M app/assets/images/tab_div.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M app/assets/stylesheets/cssgrids-responsive-min.css View 1 chunk +1 line, -1 line 0 comments Download
M app/templates/charm.handlebars View 1 chunk +1 line, -1 line 0 comments Download
M app/templates/service-header.partial View 2 chunks +15 lines, -15 lines 0 comments Download
M app/templates/show_units_large.handlebars View 1 chunk +1 line, -1 line 0 comments Download
M lib/views/stylesheet.less View 4 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 6
rharding
Please take a look.
11 years ago (2013-03-27 14:55:51 UTC) #1
rharding
lgtm code-wise. I'll pull and submit a second lgtm once qa'd. https://codereview.appspot.com/8055043/diff/1/lib/views/stylesheet.less File lib/views/stylesheet.less (right): ...
11 years ago (2013-03-27 18:11:07 UTC) #2
rharding
lgtm QA-wise with the note below. It's not responsive at all on the current code ...
11 years ago (2013-03-27 18:29:56 UTC) #3
jeff.pihach
LGTM - although when it gets below a certain size it adds a margin back ...
11 years ago (2013-03-27 18:40:01 UTC) #4
rharding
*** Submitted: Update more parts to use YUI responsive. - Submitted on behalf of Huw ...
11 years ago (2013-03-27 18:46:10 UTC) #5
gary.poster
11 years ago (2013-03-28 13:14:08 UTC) #6
On 2013/03/27 18:40:01, jeff.pihach wrote:
> LGTM - although when it gets below a certain size it adds a margin back around
> the environment exposing the brown side bars pushing the page off alignment.

As I said to Rick on IRC, please be careful of regressions.  We need to be able
to make a release from trunk at a moment's notice.  (Thank you to Rick for
filing bug 1161375.)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b