code review 8051044: cmd/gc: update runtime.go for new map implementation.

cmd/gc: update runtime.go for new map implementation.

[remyoudompheng, 2013-03-27 20:32:37]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2013-03-27 20:34:48]

What does this affect?

On Wed, Mar 27, 2013 at 1:32 PM, <remyoudompheng@gmail.com> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> cmd/gc: update runtime.go for new map implementation.
>
> Please review this at
https://codereview.appspot.**com/8051044/<https://codereview.appspot.com/8051...
>
> Affected files:
>   M src/cmd/gc/runtime.go
>
>
> Index: src/cmd/gc/runtime.go
> ==============================**==============================**=======
> --- a/src/cmd/gc/runtime.go
> +++ b/src/cmd/gc/runtime.go
> @@ -89,7 +89,13 @@
>  // *byte is really *runtime.Type
>  func makemap(mapType *byte, hint int64) (hmap map[any]any)
>  func mapaccess1(mapType *byte, hmap map[any]any, key any) (val any)
> +func mapaccess1_fast32(mapType *byte, hmap map[any]any, key any) (val
> *any)
> +func mapaccess1_fast64(mapType *byte, hmap map[any]any, key any) (val
> *any)
> +func mapaccess1_faststr(mapType *byte, hmap map[any]any, key any) (val
> *any)
>  func mapaccess2(mapType *byte, hmap map[any]any, key any) (val any, pres
> bool)
> +func mapaccess2_fast32(mapType *byte, hmap map[any]any, key any) (val
> *any, pres bool)
> +func mapaccess2_fast64(mapType *byte, hmap map[any]any, key any) (val
> *any, pres bool)
> +func mapaccess2_faststr(mapType *byte, hmap map[any]any, key any) (val
> *any, pres bool)
>  func mapassign1(mapType *byte, hmap map[any]any, key any, val any)
>  func mapiterinit(mapType *byte, hmap map[any]any, hiter *any)
>  func mapdelete(mapType *byte, hmap map[any]any, key any)
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[remyoudompheng, 2013-03-27 20:36:28]

On 2013/3/27 Brad Fitzpatrick <bradfitz@golang.org> wrote:
> What does this affect?
>

This file is used to generate src/cmd/gc/builtin.c
Revision 0fce55d10d18 edited builtin.c manually without editing runtime.go

Rémy.

[bradfitz, 2013-03-27 20:37:17]

builtin.c doesn't start with the normal OMG AUTOGENERATED prelude. That
should also be fixed.

On Wed, Mar 27, 2013 at 1:36 PM, Rémy Oudompheng
<remyoudompheng@gmail.com>wrote:

> On 2013/3/27 Brad Fitzpatrick <bradfitz@golang.org> wrote:
> > What does this affect?
> >
>
> This file is used to generate src/cmd/gc/builtin.c
> Revision 0fce55d10d18 edited builtin.c manually without editing runtime.go
>
> Rémy.
>

[remyoudompheng, 2013-03-27 20:41:58]

Hello golang-dev@googlegroups.com, bradfitz@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[bradfitz, 2013-03-27 20:47:54]

LGTM

thanks!

On Wed, Mar 27, 2013 at 1:41 PM, <remyoudompheng@gmail.com> wrote:

> Hello golang-dev@googlegroups.com, bradfitz@golang.org (cc:
> golang-dev@googlegroups.com),
>
> Please take another look.
>
>
>
https://codereview.appspot.**com/8051044/<https://codereview.appspot.com/8051...
>

[r, 2013-03-27 20:48:48]

LGTM

[remyoudompheng, 2013-03-27 20:51:11]

*** Submitted as https://code.google.com/p/go/source/detail?r=7cd19e1a734a ***

cmd/gc: update runtime.go for new map implementation.

R=golang-dev, bradfitz, r
CC=golang-dev
https://codereview.appspot.com/8051044