Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(172)

Issue 805044: IPv4RawSocket and UdpSocket returns wrong value after send (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by Hajime Tazaki
Modified:
12 years, 2 months ago
Reviewers:
Mathieu Lacage
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

This changeset is created against ns-3-dev, revision 6168. The patch aims to fix the problem when calling SendTo method in IPv4RawSocketImpl and UdpSocketImpl, which returns wrong value (it should return transmitted size of the packet in success).

Patch Set 1 #

Patch Set 2 : Added RELEASE_NOTES #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M RELEASE_NOTES View 1 chunk +4 lines, -0 lines 0 comments Download
M src/internet-stack/ipv4-raw-socket-impl.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M src/internet-stack/udp-socket-impl.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5
Hajime Tazaki
Please find new patchset to fix the return value of SendTo () method in Ipv4RawSocketImpl ...
12 years, 4 months ago (2010-04-02 17:26:15 UTC) #1
Mathieu Lacage
I think that the patch looks good: josh is this material ok for ns-3-dev now ...
12 years, 4 months ago (2010-04-02 18:50:06 UTC) #2
Josh Pelkey
Does this patch fix a bug filed in the tracker? If so, go for it. ...
12 years, 4 months ago (2010-04-02 20:58:57 UTC) #3
Hajime Tazaki
It isn't filled in bugzilla. Should I? On 2010/04/02 20:58:57, Josh Pelkey wrote: > Does ...
12 years, 4 months ago (2010-04-03 00:59:08 UTC) #4
Hajime Tazaki
12 years, 2 months ago (2010-06-02 01:03:45 UTC) #5
fixed in ns-3.8

Bug 868 - invalid packet size after Ipv4L3Protocol::Send
http://www.nsnam.org/bugzilla/show_bug.cgi?id=868

On 2010/04/03 00:59:08, Hajime Tazaki wrote:
> It isn't filled in bugzilla. Should I?
> 
> On 2010/04/02 20:58:57, Josh Pelkey wrote:
> > Does this patch fix a bug filed in the tracker?  If so, go for it.
> > 
> > --
> > Josh
> > 
> > On Fri, Apr 2, 2010 at 2:50 PM,  <mailto:mathieu.lacage@gmail.com> wrote:
> > > I think that the patch looks good: josh is this material ok for ns-3-dev
> > > now ?
> > >
> > > http://codereview.appspot.com/805044/show
> > >
> > > --
> > > You received this message because you are subscribed to the Google Groups
> > > "ns-3-reviews" group.
> > > To post to this group, send email to mailto:ns-3-reviews@googlegroups.com.
> > > To unsubscribe from this group, send email to
> > > mailto:ns-3-reviews+unsubscribe@googlegroups.com.
> > > For more options, visit this group at
> > > http://groups.google.com/group/ns-3-reviews?hl=en.
> > >
> > >
> >
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b