Issue 8046043: code review 8046043: net/http: new server-only, single-connection keep-alive...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8046043: code review 8046043: net/http: new server-only, single-connection keep-alive... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by bradfitz

Modified:
11 years, 11 months ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

net/http: new server-only, single-connection keep-alive benchmark

Patch Set 2 : diff -r 2eb36d0ca449 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 2eb36d0ca449 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 4 : diff -r 030625a923ca https://go.googlecode.com/hg/ #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -20 lines)			Patch
	M	src/pkg/net/http/serve_test.go	View	1 2 3	3 chunks	+77 lines, -20 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 11 months ago (2013-03-27 06:23:46 UTC) #1

bradfitz

Anybody? This is simple, and just a benchmark. On Tue, Mar 26, 2013 at 11:23 ...

11 years, 11 months ago (2013-03-27 20:11:36 UTC) #2

LGTM https://codereview.appspot.com/8046043/diff/5001/src/pkg/net/http/serve_test.go File src/pkg/net/http/serve_test.go (right): https://codereview.appspot.com/8046043/diff/5001/src/pkg/net/http/serve_test.go#newcode1664 src/pkg/net/http/serve_test.go:1664: n int too many n's in the Read ...

11 years, 11 months ago (2013-03-27 20:24:10 UTC) #3

bradfitz

11 years, 11 months ago (2013-03-27 20:35:43 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=310e55e6ddc5 ***

net/http: new server-only, single-connection keep-alive benchmark

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/8046043

Expand All Messages | Collapse All Messages