code review 80400043: runtime: ignore windows exception if not in Go binary

runtime: ignore windows exception if not in Go binary

[brainman, 2014-03-26 06:00:23]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[brainman, 2014-03-26 06:36:27]

Without this CL this happens on my windows xp computer:

C:\>go test os/user
Exception 0x6ba 0x1003f 0x0 0x7c812afb
PC=0x7c812afb
signal arrived during cgo execution

syscall.Syscall6(0x77fec10b, 0x5, 0x10ba59c0, 0x2, 0x3, ...)
        C:/go/root/src/pkg/runtime/syscall_windows.goc:72 +0x4b
syscall.TranslateName(0x10ba59c0, 0x2, 0x3, 0x30c8bd88, 0x30c8bd78, ...)
        c:/go/root/src/pkg/syscall/zsyscall_windows_386.go:1613 +0xa0
syscall.TranslateAccountName(0x10ba0240, 0xc, 0x2, 0x3, 0x32, ...)
        c:/go/root/src/pkg/syscall/security_windows.go:46 +0x17d
os/user.lookupFullNameDomain(0x10ba0240, 0xc, 0x0, 0x0, 0x0, ...)
        c:/go/root/src/pkg/os/user/lookup_windows.go:26 +0x6a
os/user.lookupFullName(0x10ba0230, 0x3, 0x10ba0110, 0x8, 0x10ba0240, ...)
        c:/go/root/src/pkg/os/user/lookup_windows.go:55 +0x81
os/user.newUser(0x10ba6408, 0x10ba8210, 0x2c, 0x10ba8390, 0x22, ...)
        c:/go/root/src/pkg/os/user/lookup_windows.go:83 +0x203
os/user.current(0x0, 0x0, 0x0)
        c:/go/root/src/pkg/os/user/lookup_windows.go:119 +0x191
os/user.Current(0x10bca180, 0x0, 0x0)
        c:/go/root/src/pkg/os/user/lookup.go:9 +0x33
os/user.TestCurrent(0x10bca180)
        c:/go/root/src/pkg/os/user/user_test.go:21 +0x59
testing.tRunner(0x10bca180, 0x5e74e0)
        c:/go/root/src/pkg/testing/testing.go:422 +0xa9
created by testing.RunTests
        c:/go/root/src/pkg/testing/testing.go:503 +0x70b

goroutine 16 [chan receive]:
testing.RunTests(0x57aa40, 0x5e74e0, 0x3, 0x3, 0x420101)
        c:/go/root/src/pkg/testing/testing.go:504 +0x731
testing.Main(0x57aa40, 0x5e74e0, 0x3, 0x3, 0x5eb960, ...)
        c:/go/root/src/pkg/testing/testing.go:435 +0xa0
main.main()
        C:/DOCUME~1/brainman/LOCALS~1/Temp/go-build174224715/os/user/_test/_test
main.go:51 +0x82
eax     0x6f8d8
ebx     0x1
ecx     0x7b1e
edx     0x0
edi     0x767a35b0
esi     0x0
ebp     0x6f928
esp     0x6f8d4
eip     0x7c812afb
eflags  0x246
cs      0x1b
fs      0x3b
gs      0x0
FAIL    os/user 0.063s

Alex

[minux1, 2014-03-27 06:02:27]

https://codereview.appspot.com/80400043/diff/20001/src/pkg/runtime/os_windows...
File src/pkg/runtime/os_windows_386.c (right):

https://codereview.appspot.com/80400043/diff/20001/src/pkg/runtime/os_windows...
src/pkg/runtime/os_windows_386.c:39: if(info->ExceptionCode ==
DBG_PRINTEXCEPTION_C)
add { here

[brainman, 2014-03-28 01:40:03]

Thank you for review.

Alex

https://codereview.appspot.com/80400043/diff/20001/src/pkg/runtime/os_windows...
File src/pkg/runtime/os_windows_386.c (right):

https://codereview.appspot.com/80400043/diff/20001/src/pkg/runtime/os_windows...
src/pkg/runtime/os_windows_386.c:39: if(info->ExceptionCode ==
DBG_PRINTEXCEPTION_C)
On 2014/03/27 06:02:27, minux wrote:
> add { here

Done both here and amd64.

[brainman, 2014-03-28 01:40:20]

Hello golang-codereviews@googlegroups.com, minux.ma@gmail.com (cc:
golang-codereviews@googlegroups.com),

Please take another look.

[minux1, 2014-03-28 04:33:27]

LGTM.

[brainman, 2014-03-28 06:35:12]

*** Submitted as https://code.google.com/p/go/source/detail?r=70fdb079c44e ***

runtime: ignore windows exception if not in Go binary

LGTM=minux.ma
R=golang-codereviews, minux.ma
CC=golang-codereviews
https://codereview.appspot.com/80400043

[gobot, 2014-03-28 06:47:04]

This CL appears to have broken the freebsd-386 builder.
See http://build.golang.org/log/f3c192fa64d9605e8bf0d27315e87e01493ba7cd

[rsc, 2014-03-28 15:31:55]

Yay, thank you very much Alex.

The build breakage reported by gobot is different, my fault, and should now
be fixed.