Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(257)

Issue 80370045: code review 80370045: cmd/cc: emit gc bitmaps in read-only memory (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 9 months ago by rsc
Modified:
7 years, 9 months ago
Reviewers:
gobot, khr
CC:
khr, golang-codereviews
Visibility:
Public.

Description

cmd/cc: emit gc bitmaps in read-only memory Cuts hello world by 70kB, because we don't write those names into the symbol table. Update issue 6853

Patch Set 1 #

Patch Set 2 : diff -r 4ca10cc10176 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 4ca10cc10176 https://code.google.com/p/go/ #

Patch Set 4 : diff -r cc7e3b7f79b7 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/cmd/cc/pgen.c View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/ld/symtab.c View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
rsc
Hello khr (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
7 years, 9 months ago (2014-04-03 16:26:14 UTC) #1
khr
LGTM.
7 years, 9 months ago (2014-04-03 20:35:43 UTC) #2
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=a17b32e26f72 *** cmd/cc: emit gc bitmaps in read-only memory Cuts hello world ...
7 years, 9 months ago (2014-04-03 23:04:21 UTC) #3
gobot
7 years, 9 months ago (2014-04-04 04:47:03 UTC) #4
Message was sent while issue was closed.
This CL appears to have broken the plan9-386-cnielsen builder.
See http://build.golang.org/log/969f0767db3a6c5ee4cb25ceebe5c1747e8814c7
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b