Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(634)

Issue 8030046: code review 8030046: vet: add a progress message to asmdecl.go (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by r
Modified:
11 years, 11 months ago
Reviewers:
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

vet: add a progress message to asmdecl.go Analogous to the one for .go files, it's for .s only and is protected by the verbose flag.

Patch Set 1 #

Patch Set 2 : diff -r 8039bd09662b https://code.google.com/p/go #

Patch Set 3 : diff -r 8039bd09662b https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/cmd/vet/asmdecl.go View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
11 years, 11 months ago (2013-03-27 23:42:17 UTC) #1
bradfitz
LGTM On Wed, Mar 27, 2013 at 4:42 PM, <r@golang.org> wrote: > Reviewers: golang-dev1, > ...
11 years, 11 months ago (2013-03-27 23:45:59 UTC) #2
r
11 years, 11 months ago (2013-03-27 23:55:20 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=c879a45c3389 ***

vet: add a progress message to asmdecl.go
Analogous to the one for .go files, it's for .s only and is protected
by the verbose flag.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/8030046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b